v0.24.0-1 QA Review #1870

Activity

1. smashwilson

   added

   qualityQuality assurance pass checklist for a prerelease versionQuality assurance pass checklist for a prerelease version

   on Jan 2, 2019
2. smashwilson commented on Jan 2, 2019

   

   smashwilson

   on Jan 2, 2019

   ContributorAuthor

   More actions

   Holding the release until we can fix #1868.
3. robertrossmann commented on Jan 3, 2019

   

   robertrossmann

   on Jan 3, 2019

   Last edited by robertrossmann

   Contributor

   More actions

   Not sure if this is the right place to report QA-related feedback, but here are some some issues and general suggestions. Let me know if you'd like me to split these into separate issues. 😇

   Pull request tabs' titles have selectable text

   Breaks the feeling of them being buttons.

   

   ---

   Spacing before Show more on a commit message

   While looking at pull request details => commits, the Show more button is too close to the commit message.

   

   ---

   Opening very large diffs from the "Recent commits" actually opens the very large diff

   I think there used to be that Diff too large warning when I click on a file with staged changes with too many lines - not sure if that's been removed or if this is a regression, but for diffs with tens of thousands of changed lines Atom still becomes very unresponsive while rendering the diff.

   Steps to reproduce:

   1. Clone the tree-sitter-javascript project and open this commit in Atom: tree-sitter/tree-sitter-javascript@1996b31
   2. Observe Atom hanging for several minutes while rendering the diff

   Expected behaviour:

   Github detects a large diff and skips rendering the diff for large files or warns before opening the diff pane

   ---

   UI/UX suggestions

   Show committer's name in commit details pane

   I usually recognise my co-workers/fellow open-sourcerers by their names, or by their Github handles. I would prefer to see at least the committer's name in the commit details pane.

   Stretch goal: show a card on hover with additional information fetched from Github (inspiration)

   

   ---

   Add a Copy commit shasum button wherever a shasum is shown in commit details panes

   Being able to copy the commit shasum would be great for continuing my work in other tools (ie. the git CLI). This could be especially useful on the pull request details pane.

   

   

   Alternatively, show the full commit shasum as text somewhere so the user can copy it manually.

   ---

   Hopefully you'll find this feedback useful. Nice work! ❤️
4. smashwilson commented on Jan 3, 2019

   

   smashwilson

   on Jan 3, 2019

   ContributorAuthor

   More actions

   @robertrossmann Oh wow, thanks! This is super thorough and helpful.

   Not sure if this is the right place to report QA-related feedback [..]

   You're right, I think we'd prefer to track these as separate issues rather than grouping them all here. You've already taken the trouble to write it all up, though, so I can handle the splitting 😄

   These QA issues are part of the way we ship - they're intended to be a final, simple smoke test to ensure that all of the bugs and features we think we're releasing still actually work once we tag a release and include it in a full Atom build as a bundled module distributed within Atom's startup snapshot. Historically, we've had a few pretty bad problems that almost made it to release because they were hidden by our usual testing M.O. of installing the package non-bundled from git, and linking it in dev mode. With that in mind, I'll hold up 0.24.0 tag for the graphical glitches you've found, but the others we'll keep as issues for a future sprint to keep our release scope from creeping.
5. robertrossmann commented on Jan 3, 2019

   

   robertrossmann

   on Jan 3, 2019

   Contributor

   More actions

   Thank you @smashwilson for the explanation - in the future, I'll open up separate issues for all of these. ❤️
6. smashwilson commented on Jan 3, 2019

   

   smashwilson

   on Jan 3, 2019

   ContributorAuthor

   More actions

   Okay, I think I got them all; the "large diff" gate issue was already captured here: #1759.

   Thank you @smashwilson for the explanation - in the future, I'll open up separate issues for all of these. ❤️

   ✨ 👍

   ❤️React with ❤️1Reacted by Robert Rossmann
7. smashwilson commented on Jan 3, 2019

   

   smashwilson

   on Jan 3, 2019

   ContributorAuthor

   More actions

   Next release candidate QA checklist: #1879
8. smashwilson

   closed this as completedon Jan 3, 2019