You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reacted by Carol Willing, Simon Hartmann, Evpok, Filip Todic, Dimosthenis Kaponis, Jannik Vieten, Jason Kuhrt, Adam B., Przemysław Melnarowicz, Omer Katz and 2 more
That is the point : having a bundled pyls would remove the need to install it globally. As for working with virtualenvs, there could be a setting switch to use pyls from $PATH (an thus from virtualenv) instead of the bundled one.
This would really simplify the setup process and avoids cluttering the user's python environment.
I guess the way to go is a separate virtualenv inside the atom config folder, where pyls and its dependencies can live. Or do you have another mechanism in mind?
Personally, I would consider it the greatest benefit when ide-python would occasionally check for new versions of these installed packages. This would give the user easy and automated access to the newest version of pyls and the other packages. But I'm not sure how such occasional update checks can be implemented. I see issues in other ide-x packages where this is not solved.
It is already quite straightforward to install user-wide via pip install --user python-language-server. I am not convinced with the benefits of bundling in this particular case. Meanwhile, you'd have to maintain the bundled copy or setup scripts depending on your bundling method of choice.
Actually, I came across a use case where bundling does make sense: installation of Atom via flatpak. Due to the sandboxing nature of flatpak, Atom cannot have access to the user's or system's pyls. Installing pyls alongside ide-python would solve this issue. The path of the pyls executable could be made configurable so that it could point to the user's or system's one if need be.
Currently, the Atom flatpak maintainer circumvents this limitation by bundling pyls within the flatpak bundle, but this approach won't scale as the popularity of language servers increases. Instead, I would expect Atom-IDE packages to install everything required for their use, including the corresponding language server itself.
Cool, thanks everybody for the great suggestions.
I probably won't get to this any time soon, but I'm happy to take contributions if you're interested in making this happen.
Do note that pyls is affected by the version of Python it is ran with. And even when vendored it should probably still be possible to use your own installation of pyls if you want an updated version.
Activity
stavinsky commentedon Sep 18, 2017
Do you think that is good idea? Many of us use different virtualenvs and don't want to put pyls globally for example.
Evpok commentedon Sep 18, 2017
That is the point : having a bundled
pylswould remove the need to install it globally. As for working with virtualenvs, there could be a setting switch to usepylsfrom$PATH(an thus from virtualenv) instead of the bundled one.exploide commentedon Oct 5, 2017
This would really simplify the setup process and avoids cluttering the user's python environment.
I guess the way to go is a separate virtualenv inside the atom config folder, where pyls and its dependencies can live. Or do you have another mechanism in mind?
Personally, I would consider it the greatest benefit when ide-python would occasionally check for new versions of these installed packages. This would give the user easy and automated access to the newest version of pyls and the other packages. But I'm not sure how such occasional update checks can be implemented. I see issues in other ide-x packages where this is not solved.
ghisvail commentedon Oct 15, 2017
It is already quite straightforward to install user-wide via
pip install --user python-language-server. I am not convinced with the benefits of bundling in this particular case. Meanwhile, you'd have to maintain the bundled copy or setup scripts depending on your bundling method of choice.ghisvail commentedon Jan 9, 2018
Actually, I came across a use case where bundling does make sense: installation of Atom via
flatpak. Due to the sandboxing nature offlatpak, Atom cannot have access to the user's or system'spyls. Installingpylsalongsideide-pythonwould solve this issue. The path of thepylsexecutable could be made configurable so that it could point to the user's or system's one if need be.Currently, the Atom flatpak maintainer circumvents this limitation by bundling
pylswithin the flatpak bundle, but this approach won't scale as the popularity of language servers increases. Instead, I would expect Atom-IDE packages to install everything required for their use, including the corresponding language server itself.lgeiger commentedon Jan 10, 2018
Cool, thanks everybody for the great suggestions.
I probably won't get to this any time soon, but I'm happy to take contributions if you're interested in making this happen.
segevfiner commentedon Jan 22, 2018
Do note that pyls is affected by the version of Python it is ran with. And even when vendored it should probably still be possible to use your own installation of pyls if you want an updated version.
bhack commentedon Jan 23, 2018
Can we check at least if we are using the last/right release?