Repository navigation
fix: respect timeout when polling in ActorClient.call() and TaskClient.call() - #1184
Merged
Merged
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
github-actions
Bot
added
the
t-tooling
vdusek
changed the title
wait_for_finish in Actor and task call
vdusek
changed the title
wait_for_finish in Actor and task callActorClient.call() and TaskClient.call()
vdusek
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call(timeout=...)towait_for_finishfor both Actor and Task clients, sync and async, including Actor log redirection. The timeout remains per HTTP request;wait_durationstill controls overall waiting.Fixes #1171.
Verification
uv run --extra httpx2 --extra brotli pytest tests/unit/test_call_poll_timeout.py -q -o addopts='' --tb=short-> 4 failures: polls receivedwait_durationwithouttimeout. For the log-redirection branches, the same command with-k log_redirectagainst the original calls -> 2 expected failures.uv run --extra httpx2 --extra brotli pytest tests/unit/test_call_poll_timeout.py -q -o addopts='' --tb=short-> 6 passed.uv run --extra httpx2 --extra brotli pytest tests/unit -q -n 4 -o addopts='' --tb=short-> 2418 passed, 1 skipped (Python 3.15 model generator incompatibility).uv run --extra httpx2 --extra brotli poe check-docstrings-> passed; touched-fileruff check,ruff format --check,ty check, andgit diff --check-> passed.AI assistance: implementation and tests were drafted with an AI coding assistant and verified locally. No live Apify API calls were made.