Repository navigation
Fix/vulnerabilities - #707
Merged
Merged
Conversation
ThieryMichel
force-pushed
the
fix/vulnerabilities
branch
from
November 9, 2026 10:11
196f1f9 to
a8a5e94
Compare
ThieryMichel
marked this pull request as ready for review
November 9, 2026 11:03
pysnooLab
approved these changes
Nov 10, 2026
slax57
reviewed
Nov 10, 2026
Fix vulnerabilities through in-range lockfile bumps instead. terser-webpack-plugin 5.6 no longer depends on serialize-javascript.
restDataProvider imported query-string without declaring it; use @marmelab/query-string like ra-data-simple-rest.
Drops the vulnerable react-router v6 and compression (pinned by serve).
Storybook 8.6.19 listens on 127.0.0.1 by default; bind to 0.0.0.0 in the container and publish the port on the host loopback only.
ThieryMichel
force-pushed
the
fix/vulnerabilities
branch
from
November 10, 2026 10:34
c5f9da8 to
ed87c3d
Compare
slax57
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability fixes
This PR fixes 131 of 153 npm advisories and all 51 Composer advisories that
yarn auditandcomposer auditreport onmain. The 22 npm advisories left have no fix that fits the current dependency ranges; each one is explained below.mainyarn.lockapi/composer.lockCounts are unique advisories (GHSA or CVE IDs), so they can be matched against Dependabot alerts.
Scope. All of these are in the repository's own lockfiles: dev tooling, Storybook, and the demo API in
api/. The published package has no lockfile, so apps that install@api-platform/adminresolve their own versions. Its dependency ranges are unchanged apart from the new@marmelab/query-stringdependency.react-adminstays at^5.15.5, so apps can still resolve 5.15.5, which pulls in the vulnerabledecode-uri-component.All vulnerability
resolutionsare removed frompackage.json. Every fix here comes from a lockfile refresh or a dependency bump.Fixed: npm (
yarn.lock)131 of 153 advisories reported by
yarn auditonmainare fixed.storybook8.6.15 → 8.6.19react-router ^6resolution (v7 no longer uses it)servewithhttp-serverreact-admin5.15.6 (ra-core droppedquery-string)rimraf5 → 6terser-webpack-plugin5.6 no longer depends on itreact-router ^6resolution (now v7)servewithhttp-serverFixed: Composer (
api/composer.lock, demo API)All 51 advisories reported by
composer auditonmainare fixed;composer auditon this branch reports none.composer updatecomposer update, aligned to the app's Symfony 6.4 constraintcomposer updatecomposer update, aligned to the app's Symfony 6.4 constraintcomposer updatecomposer.jsonfloor raised to^4.1.30composer updatecomposer updatecomposer updatecomposer update, aligned to the app's Symfony 6.4 constraintcomposer updatecomposer update, aligned to the app's Symfony 6.4 constraintcomposer update, aligned to the app's Symfony 6.4 constraintcomposer updatecomposer updatecomposer updateNot fixed
jsonld8 →@digitalbazaar/http-client3, both directly and through@api-platform/api-doc-parser^5. jsonld 9 moves to http-client 4 (undici 6), but api-doc-parser 0.16.12 still requiresjsonld ^8.3.3.mainalready requiresjsonld ^9(api-platform/api-doc-parser#183), but that isn't released yet. Once it is, bump it andjsonldto^9here. undici is only used by Node.js code; browser builds swap it out through http-client'sbrowserfield.@storybook/builder-webpack5^6.1.2, still true in Storybook 10.@storybook/react-vite). Onlystorybook devuses it.@typescript-eslint/*7 →typescript-estree^10.2.2.@storybook/addon-actions;jest-junitandnycthrough@storybook/test-runner@storybook/test-runnerrelease still requiresjest-junit ^16andnyc ^15.bufargument.jest,fork-ts-checker-webpack-pluginOther changes needed for these fixes
restDataProviderimportedquery-stringwithout declaring it, and ra-core 5.15.6 no longer installs it. It now imports@marmelab/query-string, which has the same API and is whatra-data-simple-restuses, and declares it independencies.useParams, which works the same in v6 and v7; apps keep whichever version react-admin's range (^6.28.1 || ^7.1.1) gives them.serveis replaced withhttp-server.storybook:servenow takes its port from the caller; CI already passes-p 3000.--host 0.0.0.0, andcompose.yamlpublishes port 3000 on the host's 127.0.0.1 only.api/composer.json:api-platform/coreraised to^4.1.30, andconfig.platform.phpset to8.2.0. A few Symfony components that had been resolved to 7.x are aligned with the app's6.4.*constraint.Verification
yarn test(74/74),tsc --noEmit,eslint srcandstorybook buildpass.composer auditreports no advisories.