Skip to content

Use column header constants in pipe authentication assertions #19131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 2 commits into from
Nov 6, 2026
Merged

Use column header constants in pipe authentication assertions #19131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
686e1cd
Use column header constants in pipe user assertions
Caideyipi Nov 5, 2026
51a15f5
Use canonical column names in pipe privilege assertions
Caideyipi Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...st/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/manual/IoTDBPipeInclusionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import org.apache.iotdb.common.rpc.thrift.TSStatus;
import org.apache.iotdb.commons.client.sync.SyncConfigNodeIServiceClient;
import org.apache.iotdb.commons.schema.column.ColumnHeaderConstant;
import org.apache.iotdb.confignode.rpc.thrift.TCreatePipeReq;
import org.apache.iotdb.db.it.utils.TestUtils;
import org.apache.iotdb.it.env.cluster.node.DataNodeWrapper;
Expand Down Expand Up @@ -303,7 +304,10 @@ public void testAuthExclusion() throws Exception {
TestUtils.executeNonQuery(senderEnv, "create user `ln_write_user` 'write_pwd123456'", null);

TestUtils.assertDataAlwaysOnEnv(
receiverEnv, "list user", "UserId,User,", Collections.singleton("0,root,"));
receiverEnv,
"list user",
ColumnHeaderConstant.USER_ID + "," + ColumnHeaderConstant.USER + ",",
Collections.singleton("0,root,"));
}
}

Expand Down Expand Up @@ -350,7 +354,14 @@ public void testAuthInclusionWithPattern() throws Exception {
TestUtils.assertDataEventuallyOnEnv(
receiverEnv,
"LIST PRIVILEGES OF USER ln_write_user",
"Role,Scope,Privileges,GrantOption,",
ColumnHeaderConstant.ROLE
+ ","
+ ColumnHeaderConstant.SCOPE
+ ","
+ ColumnHeaderConstant.PRIVILEGES
+ ","
+ ColumnHeaderConstant.GRANT_OPTION
+ ",",
new HashSet<>(
Arrays.asList(
",,SYSTEM,true,",
Expand Down
5 changes: 3 additions & 2 deletions ...t/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/manual/IoTDBPipePermissionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import org.apache.iotdb.common.rpc.thrift.TSStatus;
import org.apache.iotdb.commons.client.sync.SyncConfigNodeIServiceClient;
import org.apache.iotdb.commons.schema.column.ColumnHeaderConstant;
import org.apache.iotdb.confignode.rpc.thrift.TCreatePipeReq;
import org.apache.iotdb.consensus.ConsensusFactory;
import org.apache.iotdb.db.it.utils.TestUtils;
Expand Down Expand Up @@ -191,7 +192,7 @@ private void assertUserEventuallyExists(final String username) {
final ResultSet resultSet = statement.executeQuery("list user")) {
boolean found = false;
while (resultSet.next()) {
if (username.equals(resultSet.getString("User"))) {
if (username.equals(resultSet.getString(ColumnHeaderConstant.USER))) {
found = true;
break;
}
Expand Down Expand Up @@ -256,7 +257,7 @@ public void testNoPermission() throws Exception {
TestUtils.assertDataAlwaysOnEnv(
receiverEnv,
"list user",
"UserId,User,",
ColumnHeaderConstant.USER_ID + "," + ColumnHeaderConstant.USER + ",",
new HashSet<>(Arrays.asList("0,root,", "10000,thulab,")));
}
}
Expand Down
Loading