Skip to content

Ensure Session.close() closes all connections after failures - #19104

Merged
jt2594838 merged 2 commits into
masterfrom
fix/session-close-cleanup
Nov 4, 2026
Merged

jt2594838 merged 2 commits into
masterfrom
fix/session-close-cleanup

Cover query-only session connection cleanup

bbc7270
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 3, 2026 in 5m 47s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 285 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipePluginInfo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 106).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftIJy97lfKRter7-P&open=AaGftIJy97lfKRter7-P&pullRequest=19104

Check warning on line 148 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SubscriptionPrefetchingTsFileQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 171).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftFFa97lfKRter777&open=AaGftFFa97lfKRter777&pullRequest=19104

Check warning on line 1068 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/executor/RegionWriteExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 114).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftC3U97lfKRter760&open=AaGftC3U97lfKRter760&pullRequest=19104

Check warning on line 86 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/MaxMinByBaseAccumulator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 114).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftCu997lfKRter76s&open=AaGftCu997lfKRter76s&pullRequest=19104

Check warning on line 803 in iotdb-client/cli/src/main/i18n/en/org/apache/iotdb/cli/i18n/CliMessages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this String concatenation with Text block.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftLqT97lfKRter7_v&open=AaGftLqT97lfKRter7_v&pullRequest=19104

Check warning on line 360 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 233).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftCkg97lfKRter76q&open=AaGftCkg97lfKRter76q&pullRequest=19104

Check warning on line 979 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 138).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftH2M97lfKRter79y&open=AaGftH2M97lfKRter79y&pullRequest=19104

Check warning on line 54 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/validate/TsFileOverlapValidationAndRepairTool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftF0m97lfKRter781&open=AaGftF0m97lfKRter781&pullRequest=19104

Check warning on line 1031 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 136).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftHwc97lfKRter79m&open=AaGftHwc97lfKRter79m&pullRequest=19104

Check warning on line 37 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/component/IntoComponent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 134).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftB8O97lfKRter76S&open=AaGftB8O97lfKRter76S&pullRequest=19104

Check warning on line 207 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/CommonUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 127).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftEru97lfKRter77o&open=AaGftEru97lfKRter77o&pullRequest=19104

Check warning on line 461 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionTopicAgent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 118).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftFQo97lfKRter78R&open=AaGftFQo97lfKRter78R&pullRequest=19104

Check warning on line 105 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/trigger/executor/TriggerExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 195).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftF9S97lfKRter79J&open=AaGftF9S97lfKRter79J&pullRequest=19104

Check warning on line 567 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionSource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 107).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftEYB97lfKRter77L&open=AaGftEYB97lfKRter77L&pullRequest=19104

Check warning on line 196 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SubscriptionPrefetchingTsFileQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 148).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftFFa97lfKRter779&open=AaGftFFa97lfKRter779&pullRequest=19104

Check warning on line 193 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/CommonUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 147).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftEru97lfKRter77n&open=AaGftEru97lfKRter77n&pullRequest=19104

Check warning on line 254 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 113).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftCUE97lfKRter76d&open=AaGftCUE97lfKRter76d&pullRequest=19104

Check warning on line 115 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/tsfile/ImportTsFile.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 179).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftLdR97lfKRter7_i&open=AaGftLdR97lfKRter7_i&pullRequest=19104

Check warning on line 299 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/ClientRPCServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 152).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftDJZ97lfKRter764&open=AaGftDJZ97lfKRter764&pullRequest=19104

Check warning on line 1559 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 130).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftIBC97lfKRter79-&open=AaGftIBC97lfKRter79-&pullRequest=19104

Check warning on line 369 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/iterative/IterativeOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 106).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftBCr97lfKRter75-&open=AaGftBCr97lfKRter75-&pullRequest=19104

Check warning on line 411 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/Constants.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 109).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftLWm97lfKRter7_a&open=AaGftLWm97lfKRter7_a&pullRequest=19104

Check warning on line 69 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/utils/WALPrintTool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftAi-97lfKRter751&open=AaGftAi-97lfKRter751&pullRequest=19104

Check warning on line 431 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/Constants.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 109).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftLWm97lfKRter7_d&open=AaGftLWm97lfKRter7_d&pullRequest=19104

Check warning on line 227 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/TsFileSketchTool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 124).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGftFgP97lfKRter78b&open=AaGftFgP97lfKRter78b&pullRequest=19104