Skip to content

Load: Make load SQL option VERIFY can only be set to true (A follow-up fix for #12670) #12676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 2 commits into from
Jun 6, 2024
Merged

Load: Make load SQL option VERIFY can only be set to true (A follow-up fix for #12670) #12676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d9ed4
Load: Make load SQL option VERIFY can only be set to true (A follow-u…
SteveYurongSu Jun 6, 2024
a282931
Update IoTDBRepairDataIT.java
SteveYurongSu Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBRepairDataIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ public void testRepairData() {
statement.execute("CREATE DATABASE root.tesgsg");
statement.execute("CREATE TIMESERIES root.testsg.d1.s1 WITH DATATYPE=INT32, ENCODING=PLAIN");
File tsfile = generateUnsortedFile();
statement.execute(
String.format("load \"%s\" verify=false", tsfile.getParentFile().getAbsolutePath()));
statement.execute(String.format("load \"%s\"", tsfile.getParentFile().getAbsolutePath()));

Assert.assertFalse(validate(statement));
statement.execute("START REPAIR DATA");
Expand Down
2 changes: 1 addition & 1 deletion ...b-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@ private void parseLoadFileAttributeClause(
} else if (ctx.SGLEVEL() != null) {
loadTsFileStatement.setDatabaseLevel(Integer.parseInt(ctx.INTEGER_LITERAL().getText()));
} else if (ctx.VERIFY() != null) {
if (Boolean.parseBoolean(ctx.boolean_literal().getText())) {
if (!Boolean.parseBoolean(ctx.boolean_literal().getText())) {
throw new SemanticException("Load option VERIFY can only be set to true.");
}
loadTsFileStatement.setVerifySchema(true);
Expand Down