Skip to content

Pipe: Enhance error handling logic in pipe async connector's handlers #12669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 1 commit into from
Jun 5, 2024
Merged

Pipe: Enhance error handling logic in pipe async connector's handlers #12669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions .../db/pipe/connector/protocol/thrift/async/handler/PipeTransferTabletBatchEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,20 @@ public void onComplete(final TPipeTransferResp response) {

@Override
public void onError(final Exception exception) {
LOGGER.warn(
"Failed to transfer TabletInsertionEvent batch {} (request commit ids={}).",
events.stream()
.map(
event ->
event instanceof EnrichedEvent
? ((EnrichedEvent) event).coreReportMessage()
: event.toString())
.collect(Collectors.toList()),
requestCommitIds,
exception);

connector.addFailureEventsToRetryQueue(events);
try {
LOGGER.warn(
"Failed to transfer TabletInsertionEvent batch {} (request commit ids={}).",
events.stream()
.map(
event ->
event instanceof EnrichedEvent
? ((EnrichedEvent) event).coreReportMessage()
: event.toString())
.collect(Collectors.toList()),
requestCommitIds,
exception);
} finally {
connector.addFailureEventsToRetryQueue(events);
}
}
}
22 changes: 12 additions & 10 deletions ...pipe/connector/protocol/thrift/async/handler/PipeTransferTabletInsertionEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,17 @@ public void onComplete(TPipeTransferResp response) {

@Override
public void onError(Exception exception) {
LOGGER.warn(
"Failed to transfer TabletInsertionEvent {} (committer key={}, commit id={}).",
event instanceof EnrichedEvent
? ((EnrichedEvent) event).coreReportMessage()
: event.toString(),
event instanceof EnrichedEvent ? ((EnrichedEvent) event).getCommitterKey() : null,
event instanceof EnrichedEvent ? ((EnrichedEvent) event).getCommitId() : null,
exception);

connector.addFailureEventToRetryQueue(event);
try {
LOGGER.warn(
"Failed to transfer TabletInsertionEvent {} (committer key={}, commit id={}).",
event instanceof EnrichedEvent
? ((EnrichedEvent) event).coreReportMessage()
: event.toString(),
event instanceof EnrichedEvent ? ((EnrichedEvent) event).getCommitterKey() : null,
event instanceof EnrichedEvent ? ((EnrichedEvent) event).getCommitId() : null,
exception);
} finally {
connector.addFailureEventToRetryQueue(event);
}
}
}
18 changes: 11 additions & 7 deletions ...pipe/connector/protocol/thrift/async/handler/PipeTransferTsFileInsertionEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,18 +241,22 @@ public void onComplete(final TPipeTransferResp response) {

@Override
public void onError(final Exception exception) {
LOGGER.warn(
"Failed to transfer TsFileInsertionEvent {} (committer key {}, commit id {}).",
tsFile,
event.getCommitterKey(),
event.getCommitId(),
exception);
try {
LOGGER.warn(
"Failed to transfer TsFileInsertionEvent {} (committer key {}, commit id {}).",
tsFile,
event.getCommitterKey(),
event.getCommitId(),
exception);
} catch (final Exception e) {
LOGGER.warn("Failed to log error when failed to transfer file.", e);
}

try {
if (Objects.nonNull(clientManager)) {
clientManager.adjustTimeoutIfNecessary(exception);
}
} catch (Exception e) {
} catch (final Exception e) {
LOGGER.warn("Failed to adjust timeout when failed to transfer file.", e);
}

Expand Down