Skip to content

Optimize error message when creating unsupported data type #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cpaulyz merged 2 commits into from
Jun 4, 2024
Merged

Optimize error message when creating unsupported data type #12650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c669cc
done
Cpaulyz Jun 4, 2024
d2e774c
fix IT
Cpaulyz Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions integration-test/src/test/java/org/apache/iotdb/db/it/schema/IoTDBCreateTimeseriesIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import java.util.HashSet;
import java.util.Set;

import static org.junit.Assert.assertThrows;
import static org.junit.Assert.fail;

/**
Expand Down Expand Up @@ -264,4 +265,34 @@ public void testQueryDataFromTimeSeriesWithoutData() {
}
Assert.assertEquals(0, cnt);
}

@Test
public void testIllegalInput() {
try (Connection connection = EnvFactory.getEnv().getConnection();
Statement statement = connection.createStatement()) {
statement.execute("create timeseries root.sg2.d.s1 with datatype=INT64");
assertThrows(
"Unsupported datatype: UNKNOWN",
SQLException.class,
() -> statement.execute("create timeseries root.sg2.d.s1 with datatype=UNKNOWN"));
assertThrows(
"Unsupported datatype: VECTOR",
SQLException.class,
() -> statement.execute("create timeseries root.sg2.d.s1 with datatype=VECTOR"));
assertThrows(
"Unsupported datatype: YES",
SQLException.class,
() -> statement.execute("create timeseries root.sg2.d.s1 with datatype=YES"));
assertThrows(
"Unsupported datatype: UNKNOWN",
SQLException.class,
() -> statement.execute("create device template t1 (s1 UNKNOWN, s2 boolean)"));
assertThrows(
"Unsupported datatype: VECTOR",
SQLException.class,
() -> statement.execute("create device template t1 (s1 VECTOR, s2 boolean)"));
} catch (SQLException ignored) {
fail();
}
}
}
2 changes: 1 addition & 1 deletion integration-test/src/test/java/org/apache/iotdb/db/it/selectinto/IoTDBSelectIntoIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public class IoTDBSelectIntoIT {
SELECT_INTO_SQL_LIST.add("CREATE DATABASE root.sg_type");
for (int deviceId = 0; deviceId < 6; deviceId++) {
for (TSDataType dataType : TSDataType.values()) {
if (!dataType.equals(TSDataType.VECTOR)) {
if (!dataType.equals(TSDataType.VECTOR) && !dataType.equals(TSDataType.UNKNOWN)) {
SELECT_INTO_SQL_LIST.add(
String.format(
"CREATE TIMESERIES root.sg_type.d_%d.s_%s %s",
Expand Down
3 changes: 3 additions & 0 deletions ...b-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3554,6 +3554,9 @@ private TSDataType parseDataTypeAttribute(IoTDBSqlParser.AttributeClausesContext
String dataTypeString = ctx.dataType.getText().toUpperCase();
try {
dataType = TSDataType.valueOf(dataTypeString);
if (TSDataType.UNKNOWN.equals(dataType) || TSDataType.VECTOR.equals(dataType)) {
throw new SemanticException(String.format("Unsupported datatype: %s", dataTypeString));
}
} catch (Exception e) {
throw new SemanticException(String.format("Unsupported datatype: %s", dataTypeString));
}
Expand Down