Skip to content

[Feature request] Allow Pandas >= 2 #12591

Closed

Description

@rmpinchback

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

I ran into a situation where I was trying to install several libraries via pip that had pandas dependencies, and one of them required >= 2 on the pandas version. While the requirements.txt in source control for the iotdb Python client doesn't indicate a restriction for not using pandas 2+, the metadata in the setup.py file restricts to less than v2.

Solution

If there isn't a functional reason for the limitation then I'd suggest removing the "<1.99.99" restriction. Also the minimum required version should probably be updated to agree with what is in the requirements.txt file, which it currently doesn't.

Alternatives

No real alternative comes to mind. Pandas v2 has been out for quite awhile now.

Are you willing to submit a PR?

  • I'm willing to submit a PR!

Activity

  1. github-actions commented on May 25, 2024

    @github-actions

    Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!

  2. HTHou commented on May 28, 2024

    @HTHou
    Contributor

    Hi, I don't think we have such "<1.99.99" restriction for pandas.

    Moreover, the python CI is using the latest pandas v2.2.2, and it works well.
    https://github.com/apache/iotdb/actions/runs/9262251482/job/25478871454

  3. HTHou commented on May 28, 2024

    @HTHou
    Contributor

    Oh..okay, I know where the problem is...

    "pandas>=1.0.0,<1.99.99",

    I think the restriction can be removed.

  4. rmpinchback commented on Jun 3, 2024

    @rmpinchback
    Author

    Awesome, ty! I should have mentioned setup.py, apologies for that. I had to hunt around a bit for it myself. I was seeing the effect of the constraint from Jenkins build logs, but it took a little poking around before I could see the root problem.

  5. HTHou commented on Jun 6, 2024

    @HTHou
    Contributor

    Any problem of this PR? #12601 You can give an approval if there is no problem and then I'll merge it.

  6. rmpinchback commented on Jun 6, 2024

    @rmpinchback
    Author

    Commented on the PR, thumbs up. I think you can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions