You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched in the issues and found nothing similar.
Motivation
I ran into a situation where I was trying to install several libraries via pip that had pandas dependencies, and one of them required >= 2 on the pandas version. While the requirements.txt in source control for the iotdb Python client doesn't indicate a restriction for not using pandas 2+, the metadata in the setup.py file restricts to less than v2.
Solution
If there isn't a functional reason for the limitation then I'd suggest removing the "<1.99.99" restriction. Also the minimum required version should probably be updated to agree with what is in the requirements.txt file, which it currently doesn't.
Alternatives
No real alternative comes to mind. Pandas v2 has been out for quite awhile now.
Awesome, ty! I should have mentioned setup.py, apologies for that. I had to hunt around a bit for it myself. I was seeing the effect of the constraint from Jenkins build logs, but it took a little poking around before I could see the root problem.
Activity
github-actions commentedon May 25, 2024
Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!
HTHou commentedon May 28, 2024
Hi, I don't think we have such "<1.99.99" restriction for pandas.
iotdb/iotdb-client/client-py/requirements.txt
Line 20 in baf37c3
Moreover, the python CI is using the latest pandas v2.2.2, and it works well.
https://github.com/apache/iotdb/actions/runs/9262251482/job/25478871454
HTHou commentedon May 28, 2024
Oh..okay, I know where the problem is...
iotdb/iotdb-client/client-py/resources/setup.py
Line 44 in baf37c3
I think the restriction can be removed.
rmpinchback commentedon Jun 3, 2024
Awesome, ty! I should have mentioned setup.py, apologies for that. I had to hunt around a bit for it myself. I was seeing the effect of the constraint from Jenkins build logs, but it took a little poking around before I could see the root problem.
HTHou commentedon Jun 6, 2024
Any problem of this PR? #12601 You can give an approval if there is no problem and then I'll merge it.
rmpinchback commentedon Jun 6, 2024
Commented on the PR, thumbs up. I think you can close this now.