Skip to content

fix out-of-bounds read in mod_proxy_html metafix - #783

Open
arshsmith1 wants to merge 1 commit into
apache:trunkfrom
arshsmith1:proxy-html-metafix-bounds
Open

arshsmith1 wants to merge 1 commit into
apache:trunkfrom
arshsmith1:proxy-html-metafix-bounds

Conversation

@arshsmith1

Copy link
Copy Markdown

metafix scans the backend response buffer for a header name and content value, but buf comes straight from apr_bucket_read and is not NUL terminated while the scans have no bound against buf+len. A backend body whose tag lands at the end of the bucket (with ProxyHTMLMeta on) walks past the buffer, reading adjacent heap and copying it into a response header name. Bound every scan in metafix to buf+len so a tag at the buffer boundary stops cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant