Skip to content

ui: add move to top/bottom for acl rules list #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
May 28, 2024
Merged

ui: add move to top/bottom for acl rules list #9119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/src/core/lazy_lib/icons_use.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ import {
UserOutlined,
UserSwitchOutlined,
UploadOutlined,
VerticalAlignBottomOutlined,
VerticalAlignTopOutlined,
WarningOutlined,
WifiOutlined,
SolutionOutlined
Expand Down Expand Up @@ -326,6 +328,8 @@ export default {
app.component('UserOutlined', UserOutlined)
app.component('UserSwitchOutlined', UserSwitchOutlined)
app.component('UploadOutlined', UploadOutlined)
app.component('VerticalAlignBottomOutlined', VerticalAlignBottomOutlined)
app.component('VerticalAlignTopOutlined', VerticalAlignTopOutlined)
app.component('WarningOutlined', WarningOutlined)
app.component('WifiOutlined', WifiOutlined)
app.component('renderIcon', renderIcon)
Expand Down
22 changes: 22 additions & 0 deletions ui/src/views/network/AclListRulesTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,16 @@
</div>
</div>
<div class="list__actions">
<tooltip-button
v-if="element.id !== acls[0].id"
:tooltip="$t('label.move.to.top')"
icon="vertical-align-top-outlined"
@onClick="() => moveRuleToTop(element)" />
<tooltip-button
v-if="element.id !== acls[acls.length - 1].id"
:tooltip="$t('label.move.to.bottom')"
icon="vertical-align-bottom-outlined"
@onClick="() => moveRuleToBottom(element)" />
<tooltip-button :tooltip="$t('label.tags')" icon="tag-outlined" @onClick="() => openTagsModal(element)" />
<tooltip-button :tooltip="$t('label.edit')" icon="edit-outlined" @onClick="() => openEditRuleModal(element)" />
<tooltip-button
Expand Down Expand Up @@ -632,6 +642,12 @@ export default {

if (e.moved.newIndex + 1 < this.acls.length) nextaclruleid = this.acls[e.moved.newIndex + 1].id

this.moveRule(
id,
previousaclruleid,
nextaclruleid)
},
moveRule (id, previousaclruleid, nextaclruleid) {
this.fetchLoading = true
api('moveNetworkAclItem', {
id,
Expand Down Expand Up @@ -664,6 +680,12 @@ export default {
this.fetchLoading = false
})
},
moveRuleToTop (element) {
this.moveRule(element.id, null, this.acls[0].id)
},
moveRuleToBottom (element) {
this.moveRule(element.id, this.acls[this.acls.length - 1].id, null)
},
exportAclList () {
const csvData = this.csv({ data: this.acls })

Expand Down