Skip to content

Show site to site VPN connections in UI - #9066

Merged
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:show-s2s-vpn-conn
Jun 4, 2024
Merged

DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:show-s2s-vpn-conn

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Description

This PR fixes #7249

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 linked an issue May 9, 2024 that may be closed by this pull request
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov-commenter

codecov-commenter commented May 9, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (ea9a0f4) to head (a53c51d).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9066      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10992       -3     
============================================
  Files          5373     5373              
  Lines        469024   469024              
  Branches      58818    57678    -1140     
============================================
- Hits          70197    70186      -11     
- Misses       391056   391068      +12     
+ Partials       7771     7770       -1     
Flag Coverage Δ
uitests 4.31% <ø> (ø)
unittests 15.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9066 (QA-JID-338)

@vishesh92 vishesh92 added this to the 4.19.1.0 milestone May 28, 2024

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@DaanHoogland

Copy link
Copy Markdown
Contributor

tested in qa

@DaanHoogland
DaanHoogland merged commit 68a231a into apache:4.19 Jun 4, 2024
@DaanHoogland
DaanHoogland deleted the show-s2s-vpn-conn branch June 4, 2024 12:43
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Create a Site-to-site VPN Connections tab

5 participants