Skip to content

create mode 1777 instead of 0777 #7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaanHoogland wants to merge 1 commit into from
Closed

create mode 1777 instead of 0777 #7573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/com/cloud/storage/template/OVAProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ private void setFileSystemAccessRights(String templatePath) {
LOGGER.warn("Unable to set permissions for files in " + templatePath + " due to " + result);
}
command = new Script("chmod", 0, LOGGER);
command.add("777", templatePath);
command.add("1777", templatePath);
result = command.execute();
if (result != null) {
LOGGER.warn("Unable to set permissions for " + templatePath + " due to " + result);
Expand Down
2 changes: 1 addition & 1 deletion ...pervisors/hyperv/src/main/java/com/cloud/hypervisor/hyperv/manager/HypervManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ protected String mount(String path, String parent, String scheme, String query)

// Change permissions for the mountpoint
script = new Script(true, "chmod", _timeout, s_logger);
script.add("-R", "777", mountPoint);
script.add("-R", "1777", mountPoint);
result = script.execute();
if (result != null) {
s_logger.warn("Unable to set permissions for " + mountPoint + " due to " + result);
Expand Down
4 changes: 2 additions & 2 deletions ...rc/main/java/org/apache/cloudstack/storage/resource/LocalNfsSecondaryStorageResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ protected void mount(String localRootPath, String remoteDevice, URI uri, String

// Change permissions for the mountpoint - seems to bypass authentication
Script script = new Script(true, "chmod", _timeout, s_logger);
script.add("777", localRootPath);
script.add("1777", localRootPath);
String result = script.execute();
if (result != null) {
String errMsg = "Unable to set permissions for " + localRootPath + " due to " + result;
s_logger.error(errMsg);
throw new CloudRuntimeException(errMsg);
}
s_logger.debug("Successfully set 777 permission for " + localRootPath);
s_logger.debug("Successfully set 1777 permission for " + localRootPath);

// XXX: Adding the check for creation of snapshots dir here. Might have
// to move it somewhere more logical later.
Expand Down
2 changes: 1 addition & 1 deletion test/src-not-used/main/java/com/cloud/test/stress/StressTestDirectAttach.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ private static String sshWinTest(String host) {

try {
SCPClient scp = new SCPClient(conn);
scp.put("wget.exe", "wget.exe", "C:\\Users\\Administrator", "0777");
scp.put("wget.exe", "wget.exe", "C:\\Users\\Administrator", "1777");
s_logger.info("Successfully put wget.exe file");
} catch (Exception ex) {
s_logger.error("Unable to put wget.exe " + ex);
Expand Down
2 changes: 1 addition & 1 deletion test/src-not-used/main/java/com/cloud/test/stress/TestClientWithAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@ private static String sshWinTest(String host) {

try {
SCPClient scp = new SCPClient(conn);
scp.put("wget.exe", "wget.exe", "C:\\Users\\Administrator", "0777");
scp.put("wget.exe", "wget.exe", "C:\\Users\\Administrator", "1777");
s_logger.info("Successfully put wget.exe file");
} catch (Exception ex) {
s_logger.error("Unable to put wget.exe " + ex);
Expand Down