Repository navigation
ui: show static-nat tag for public ip - #7395
Merged
Merged
Conversation
Fixes apache#7246 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@kiranchavala can you please check |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7395 +/- ##
=========================================
Coverage 12.69% 12.69%
Complexity 8661 8661
=========================================
Files 2717 2717
Lines 256168 256168
Branches 39928 39928
=========================================
Hits 32527 32527
Misses 219506 219506
Partials 4135 4135 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
DaanHoogland
approved these changes
Apr 4, 2023
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm, i will change it again in #6442 but not even a small deal...
weizhouapache
approved these changes
Apr 4, 2023
weizhouapache
left a comment
Member
There was a problem hiding this comment.
code lgtm
screenshot looks good
kishankavala
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Apr 13, 2023
Fixes apache#7246 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Fixes #7246
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?