Skip to content

ui: show static-nat tag for public ip - #7395

Merged
shwstppr merged 1 commit into
apache:4.18from
shapeblue:ui-add-ip-static-nat-tag
Apr 4, 2023
Merged

shwstppr merged 1 commit into
apache:4.18from
shapeblue:ui-add-ip-static-nat-tag

Conversation

@shwstppr

@shwstppr shwstppr commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes #7246

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2023-04-03 16-35-54

How Has This Been Tested?

Fixes apache#7246

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

shwstppr commented Apr 3, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@kiranchavala can you please check

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7395 (QA-JID-72)

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, the static nat label is working fine

staticnat

LGTM

@codecov

codecov Bot commented Apr 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7395 (a918c4b) into 4.18 (5d5fa04) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7395   +/-   ##
=========================================
  Coverage     12.69%   12.69%           
  Complexity     8661     8661           
=========================================
  Files          2717     2717           
  Lines        256168   256168           
  Branches      39928    39928           
=========================================
  Hits          32527    32527           
  Misses       219506   219506           
  Partials       4135     4135           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud

sonarqubecloud Bot commented Apr 3, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, i will change it again in #6442 but not even a small deal...

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
screenshot looks good

@shwstppr
shwstppr merged commit c35d7ac into apache:4.18 Apr 4, 2023
@DaanHoogland
DaanHoogland deleted the ui-add-ip-static-nat-tag branch April 4, 2023 13:46
kishankavala pushed a commit to shapeblue/cloudstack that referenced this pull request Apr 13, 2023
Fixes apache#7246

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@weizhouapache weizhouapache added this to the 4.18.1.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants