Repository navigation
Conversation
… for all the currently present labels.
|
@fermosan I'm not sure we have anyone else active in the community that knows greek. @DaanHoogland do you know of anyone? (except @fermosan obviously). If there is no one... I guess we trust @fermosan that his translations are accurate? |
|
@JoaoJandre We did the original translation as well back in the day if that helps. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14507 +/- ##
============================================
+ Coverage 20.63% 20.67% +0.03%
- Complexity 21695 21723 +28
============================================
Files 6489 6492 +3
Lines 590136 590728 +592
Branches 72361 72448 +87
============================================
+ Hits 121788 122108 +320
- Misses 455100 455347 +247
- Partials 13248 13273 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@fermosan , you are now solely responsible ;) or more serious; keep an eye on this please. |
|
@RosiKyu Kindly consider this as well as it is long time overdue on our part. |
You are right, we need to find time before every release and work on changes for translation. There is quite a number of people working with that translation on production systems that we know or support. |
|
@RosiKyu @nvazquez I think we'll have to trust @fermosan on this one. cc @JoaoJandre . |
nvazquez
left a comment
There was a problem hiding this comment.
LGTM (trusting the translations are correct)
Description
This PR completes and reviews the Greek (
el_GR) UI translation inui/public/locales/el_GR.json.Missing translations
en.jsonbut missing fromel_GR.json.el_GR.jsonnow has all 4521 keys inen.json.Cleanup
en.json. One of them ismessage.delete.account, which was dropped fromen.jsonin Extra checks in UI when deleting accounts #10760 and isn't shown by the account-deletion popup.JSON.parseuses the last one). Four of those values were broken (e.g.label.requireshvm= "Hεικονικής μηχανής"), so the correct value was used instead.Review of existing translations
Every existing Greek string was checked against the English and corrected where it was wrong or confusing. Some examples:
Consistent terminology
Product names, protocols and setting names (KVM, NSX,
vm.userdata.max.length, etc.) are kept in English. "Pod" stays "συνομοταξία".Only
ui/public/locales/el_GR.jsonchanges. No code changes.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
el_GR.jsonis valid JSON and has exactly the same keys asen.json(4521), with no missing, extra or duplicate keys.{placeholders},%x/%y/%zmarkers and HTML tags as its English source.en.jsonand existing lines keep their order, to keep the diff readable.How did you try to break this feature and the system with this change?
The change only touches the Greek locale file, and vue-i18n falls back to English for any missing key, so other locales and UI code are unaffected.