Repository navigation
UI: allow memory setting in flex compute offering in GiB with unit selector (#14082) - #14413
Open
saurabhkushwaha438 wants to merge 1 commit into
Open
saurabhkushwaha438 wants to merge 1 commit into
saurabhkushwaha438 wants to merge 1 commit into
Conversation
Damans227
reviewed
Oct 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14413 +/- ##
============================================
+ Coverage 19.91% 20.76% +0.84%
- Complexity 20198 21905 +1707
============================================
Files 6373 6496 +123
Lines 577230 591644 +14414
Branches 70696 72601 +1905
============================================
+ Hits 114936 122835 +7899
- Misses 449736 455471 +5735
- Partials 12558 13338 +780
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
saurabhkushwaha438
force-pushed
the
issue-14082-flex-memory-gib
branch
2 times, most recently
from
October 30, 2026 06:42
2c7e3a6 to
c401af2
Compare
Damans227
reviewed
Oct 30, 2026
Collaborator
|
@Damans227 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
…B step (apache#14082) - Add compact unit selector dropdown (GiB/MiB) for flex compute offerings - Use fixed 0.25 GiB steps in GiB mode (binary-exact to 256 MiB intervals, zero rounding errors) - Maintain integer MiB as authoritative internal state to prevent lossy conversion on load - Default to GiB for 256 MiB multiples and MiB for arbitrary sizes (e.g. 1500 MiB) - Add hover tooltip to display exact converted values
saurabhkushwaha438
force-pushed
the
issue-14082-flex-memory-gib
branch
from
November 1, 2026 06:49
c401af2 to
6c3f959
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14082
1. Conversion from MiB to GiB (Display & Rounding)
1 GiB = 1024 MiB).0.01(or smaller for sub-GiB offerings) with precision2.1with integer precision0.2. Conversion from GiB to MiB (Backend Value Emission)
minMemory/maxMemory), selecting the exact minimum or maximum bound in GiB directly maps to the exact integerminMemoryormaxMemoryin MiB to eliminate any potential off-by-one rounding discrepancies.💬 Feedback Needed: Fractional GiB to Integer MiB Rounding
1.51 GiB × 1024 = 1546.24 MiB).1546 MiB), which is then emitted in the API payload and consumed by backend hypervisor managers.Math.round) is acceptable, or if we should apply ceiling (Math.ceil) to guarantee the VM always receives at least the requested GiB amount.bandicam.2026-10-16.10-21-12-210.mp4