Repository navigation
Unable to order the ISO/templates in the UI #7278
Description
ISSUE TYPE
- Bug report
COMPONENT NAME
Componet:UI
Componet:api
CLOUDSTACK VERSION
4.18 nightly
4.17.2
SUMMARY
Unable to order the ISO/templates in the UI
Steps to reproduce the issue
-
Login as admin user
-
Navigate to Images> Iso
-
Register a sample iso (as a admin user)
-
Try to move the Order the registerd iso
Move to the top
Move to the bottom
Move up one row
Move down one row
Similarly for Images> Templates
- It works partially
Api calls
https://cloudstack.apache.org/api/apidocs-4.17/apis/updateIso.html
In the backend updateIso api call is executed with sorkey
It updates the database table vm_template.sort_key
MariaDB [cloud]> select name,sort_key from vm_template where format='iso' ;
+---------------------------------+----------+
| name | sort_key |
+---------------------------------+----------+
| vmware-tools.iso | 5 |
| xs-tools.iso | 3 |
| v1.24.0-Kubernetes-Binaries-ISO | 6 |
| v1.23.3-Kubernetes-Binaries-ISO | 4 |
| v1.22.6-Kubernetes-Binaries-ISO | 2 |
| rocky | 7 |
+---------------------------------+----------+
6 rows in set (0.00 sec
EXPECTED RESULTS
Admin User should be able to order the iso's and template based on his requirement
ACTUAL RESULTS
user is unable to order the iso's and template based on his requirement
Activity
kiranchavala commentedon Feb 22, 2023
@borisstoyanov please add the tags for this issue
borisstoyanov commentedon Feb 23, 2023
@kiranchavala are you sure this is an API issue, on first glance it seems like ui/display issue (might be wrong) ?
kiranchavala commentedon Feb 24, 2023
@borisstoyanov it could be API issue as 2 templates/iso can have the same sort_key field in the database, which can lead into issues
davidjumani commentedon Mar 14, 2023
Unrelated to the UI as the API call is correctly made but the results are not sorted
yadvr commentedon May 8, 2023
@shwstppr we need to check if it's the UI or API that's broken or re-test and close if we can't rperoduce. Certinaly works for me in 4.17.2.
CharlesQueiroz commentedon Aug 10, 2023
Guys, I reproduced the problem, and the ordering is not being maintained. I discovered that the issue is due to using a Hashtable instead of a LinkedHashMap when returning the results to the front end.
As Hashtable does not maintain the insertion order, it returns the list similarly. I've created a PR that solves this problem.
Here: #7844
If anyone could take a look, I'd appreciate it.
weizhouapache commentedon Aug 16, 2023
fixed via #7844