Repository navigation
add cpu percentage and value #4488
Description
cpu percentage and value as for memory #4478
ISSUE TYPE
- Improvement Request
COMPONENT NAME
API, metrics
CLOUDSTACK VERSION
all
CONFIGURATION
OS / ENVIRONMENT
SUMMARY
as in #4478 (for memory), cpu could have percentage and value output for use in UI or scripts
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
Activity
davidjumani commentedon Nov 20, 2020
@DaanHoogland Would this mean reverting
cpuallocatedto the original allocated value and adding a new fieldcpuallocatedwithoverprovisioning?DaanHoogland commentedon Nov 20, 2020
no, it would mean adding two new response parameters as done for memory and leaving the existing as is but deprecated. cc @weizhouapache @rhtyd
davidjumani commentedon Nov 23, 2020
@DaanHoogland It's always been a percentage, just that it was changed to consider overprovisioning in 09de5e0 So would it make sense to revert it and add a new field
cpuallocatediwthoverprovisioningfor naming consistency ?DaanHoogland commentedon Nov 23, 2020
so what would the resulting field(-names) be, @davidjumani ?
and which ones will in the endd be deprecated?
davidjumani commentedon Nov 23, 2020
I'd suggest reverting
cpuallocatedto not consider overcommit and introducingcpuallocatediwthoverprovisioningto follow the naming convention herehttps://github.com/apache/cloudstack/blob/4.14/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java#L106
https://github.com/apache/cloudstack/blob/4.14/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java#L115
yadvr commentedon Mar 6, 2021
Fixed in #4499