[API] Incorrect listing of VMs with previous NICs on networks #10188

ISSUE TYPE

• Bug

COMPONENT NAME

API, UI

CLOUDSTACK VERSION

4.19.1.2

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

CloudStack incorrectly lists VMs that previously had NICs on networks and are no longer part of the network. On database, once the NICs of the VMs are removed from the network, they appear removed and in Deallocating state, however CloudStack does not check the removed field and incorrectly lists theses VMs

STEPS TO REPRODUCE

- Create network1
- Create network2
- Deploy VM with a NIC on each network1 and network2
- Remove the non-default NIC (say network2)
- Navigate to network2 -> View instances -> The VM is still displayed

EXPECTED RESULTS

Empty results

ACTUAL RESULTS

VM with removed NIC is still displayed