Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

remove 'replace' property from tabs directive example on home page #159

Open

Description

@MokoJumbie

Considering that 'replace' is deprecated, should the use of it still be encouraged by one of the first directive code examples newcomers will see on the site?

Activity

  1. changed the title [-]remove 'replace' attribute from tabs example on home page[/-] [+]remove 'replace' property from tabs directive example on home page[/+] on Feb 4, 2015
  2. JordanMajd commented on Sep 5, 2015

    @JordanMajd

    I've been looking into this but I'm not so sure this is an issue. Even though it is currently deprecated it will not be removed until v2.0 according to the current docs. In addition, @caitp mentioned in angular/angular.js@eec6394 that

    replace: true isn't being removed. You can be pretty certain of that, like as cute as it is for us to say it's deprecated, it's not going anywhere.

    On the other hand, if this is something that needs resolved I would be interested in looking in to it.

  3. gkalpak commented on Sep 5, 2015

    @gkalpak
    Member

    While it's not going anywhere in the foreseeable future, it would be nice (imo) to not promote it (by featuring it on examples).

    If anyone is up for a PR, we could consider removing it (I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions