Can't upgrade from beta.7 to beta.8-10

After upgrade beta.7 to beta.10 I got the following error.

Error present since beta.8

Hi,
Any chance you can create an example (e.g using http://plnkr.co) ?

beta.8 includes a breaking change regarding provider registration, see

https://github.com/angular/angular.js/blob/master/CHANGELOG.md#130-beta8-accidental-haiku-2014-05-09

Maybe that's related?

Same on beta13.

The core of issue was attempt to register new filter in third party library.

angular.module('ng').filter('tel', function (){});

There are few libraries with behavior like this. It will be great to add init/lock life cycle and say directly that ng module is prohibited for extension.

Please post a repro, it's possible that it's a regression

Nevermind, I can reproduce this with http://plnkr.co/edit/txehajjSSoMV71at9Ygc?p=preview

I'll look into this today

@Narretz

The reason this happens is because now, $providers are always run before config blocks --- however in the case of the ng module, all of the work is actually done in a config block, so this breaks. (This is because of the commit @Narretz is referencing)

This is a breaking change that wasn't mentioned in the changelog, unfortunately.

Anyways, I'll put together a fix for this (but I'm not sure "extending" the ng module was ever really a supported use case)

fix(loader): allow 'ng' module to be extended with filters/directives…

@ifyify

There are few libraries with behavior like this.

@ifyify I feel like this falls under the category of "probably not the best way to do things." What are the 3rd party libraries that do this? If they are open source and on GitHub, I'd like to file issues against them.

I agree with Brian, on this one, fwiw, it's really a bizarre thing to do

this is invalid use of our apis. please create a module for your stuff rather than piggy-back on the ng module.

If mine subcontractors did that, anyone else can do it again.

You have great URL based error explanation: extend it to bad practices (for non production code base) attach to discussion thread and it will be really great.

It is the C style int32 problem, solve it and people will love you...

./F

On Jun 24, 2014, at 14:45, Igor Minar notifications@github.com wrote:

this is invalid use of our apis. please create a module for your stuff rather than piggy-back on the ng module.

—
Reply to this email directly or view it on GitHub.

Honestly, I don't think it even makes sense to document this more thoroughly.

The official Angular documentation shows how to correctly register filters.
The official Angular documentation rarely mentions the internal ng module. You have to go out of your way to find it. Nothing about the documentation or API suggests that modifying this module is a reasonable thing to do.
I explicitly added this to our list of poor practices for 3rd party components

There are so many more important things for us to work on.

docs(error/$injector/modulerr): add info about not monkey-patching `ng`

What is the solution to this issue?

@digish777

@digish777, this issue is about a very old Angular 1.x version (1.3.0.beta.8 specifically).
Are you sure you are having the same issue?

My office is trying to upgrade from 1.2.2 to 1.5. this filter is standing in the way. do not know how to fix this. that is why I asked.

http://plnkr.co/edit/txehajjSSoMV71at9Ygc?p=preview

This is exactly what is happening to me.

Uncaught Error: [$injector:modulerr] Failed to instantiate module ng due to:
Error: [$injector:unpr] Unknown provider: $filterProvider

I found the issue is happening at 1.3.0-beta.8. What got changed and how to fix it.?

The cause of the problem is explained in the comments above. In a nutshell, you should not be putting stuff on the ng module.

The proper way to solve this is to create your own module and add that as a dependency to your other modules. E.g.:

angular.
  module('utils', []).
  filter('tel', function() { ... });

angular.
  module('test', ['utils']).
  run(function(telFilter) {
    console.log(telFilter);
  });

The hacky, unrecommended, non-future-proof way to work around it is:

angular.
  module('ng').
  config(function($filterProvider) {
    $filterProvider.register('tel', function() { ... });
  });

My case was,in my HTML file, I have declared ng-app="MyApplication" in two places.
While I removed that, the error was resolved.

Navigation Menu

Repository navigation

Can't upgrade from beta.7 to beta.8-10 #7709

1 remaining item

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Can't upgrade from beta.7 to beta.8-10 #7709

Description

Activity

lgalfaso commented on Jun 5, 2014

Narretz commented on Jun 5, 2014

ifyify commented on Jun 17, 2014

caitp commented on Jun 17, 2014

caitp commented on Jun 17, 2014

caitp commented on Jun 17, 2014

caitp commented on Jun 17, 2014

btford commented on Jun 20, 2014

caitp commented on Jun 20, 2014

1 remaining item

IgorMinar commented on Jun 24, 2014

ifyify commented on Jun 24, 2014

btford commented on Jun 26, 2014

digish777 commented on Oct 6, 2016

gkalpak commented on Oct 6, 2016

digish777 commented on Oct 7, 2016

digish777 commented on Oct 7, 2016

digish777 commented on Oct 7, 2016

digish777 commented on Oct 7, 2016

gkalpak commented on Oct 7, 2016

SudhaSusarita commented on May 30, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions