You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
"Wire the backend" example: deep link broken #5396
I have a patch which I believe addresses this at angular/angularjs.org#86 --- I am not totally able to test it, but it seems reasonable that that should fix it
edit: I guess my patch is unrelated to this issue, but fixes 5716... I can't actually reproduce the issue with the deep-linking example, though, the links are all target="_blank" and work as expected, far as I can tell. If this is the result of a recent fix, maybe we should close this issue?
OK, here is the issue. If you click on the edit icon for one of the "JavaScript Projects" it correctly updates the URL and displays the edit form for that project. The trouble is that the docs app and the web server don't expect such URLs so if you navigate directly to such a URL as http://angularjs.org/edit/-JEKS-jn8XVQZ86IMXrU or you hit refresh when editing a project) you get a mess: the index.html mistakenly sets the base href to / and so all the CSS and javascript get messed up.
This may be fixable by creating a redirect on the server specifically for these "edit" URLs.
Actually we need to move this to angularjs.org repository since it is not specifically handled by the docs website right now. The good news is the using iframes in the docs, we can show that it works and is easy to fix. So we can update the angularjs.org main page at some point.
Activity
IgorMinar commentedon Jan 6, 2014
punted from 1.2.8
IgorMinar commentedon Jan 10, 2014
related issue #5716
caitp commentedon Jan 17, 2014
I have a patch which I believe addresses this at angular/angularjs.org#86 --- I am not totally able to test it, but it seems reasonable that that should fix it
edit: I guess my patch is unrelated to this issue, but fixes 5716... I can't actually reproduce the issue with the deep-linking example, though, the links are all target="_blank" and work as expected, far as I can tell. If this is the result of a recent fix, maybe we should close this issue?
petebacondarwin commentedon Jan 27, 2014
OK, here is the issue. If you click on the edit icon for one of the "JavaScript Projects" it correctly updates the URL and displays the edit form for that project. The trouble is that the docs app and the web server don't expect such URLs so if you navigate directly to such a URL as http://angularjs.org/edit/-JEKS-jn8XVQZ86IMXrU or you hit refresh when editing a project) you get a mess: the index.html mistakenly sets the base href to
/and so all the CSS and javascript get messed up.This may be fixable by creating a redirect on the server specifically for these "edit" URLs.
petebacondarwin commentedon Jan 27, 2014
And infact this will be fixed in the new docs as they will be run inside an iframe.
petebacondarwin commentedon Jan 27, 2014
Moved to bike-shed
petebacondarwin commentedon Feb 14, 2014
Actually we need to move this to angularjs.org repository since it is not specifically handled by the docs website right now. The good news is the using iframes in the docs, we can show that it works and is easy to fix. So we can update the angularjs.org main page at some point.