Skip to content

Task Scheduler Like Cron job #154

Open

Description

@lablnet

There should be package that allow to handle task scheduler / cron job cross platform

Activity

  1. peter279k commented on Mar 23, 2019

    @peter279k
    Member

    The Cron job has the two key components.

    • Cron expression parser.
      It includes specific time.
    • Cron job task manager/scheduler.

    Should we implement these all components?

  2. peter279k commented on Mar 23, 2019

    @peter279k
    Member

    You also mention about the cross platform.

    I am not familiar with the cron job task on Windows.

    I also am familiar with cron job on Linux.

  3. lablnet commented on Mar 23, 2019

    @lablnet
    MemberAuthor

    Yes should implemented all components.

    in windows there is Task Scheduler

    when you send your proposal as a pull request i will add Win task scheduler support

    write in such a way it has option to add support for windows

  4. peter279k commented on Mar 24, 2019

    @peter279k
    Member

    @lablnet, when I think this deeply, I found the following way to do Cron job package to support cross platform.

    • Using the scheduler.php to let this program run on every minute.
    • On every minute, we check the specific job should be executed.
    • We can use the log file or DB to store every task current execution time.
  5. lablnet commented on Mar 24, 2019

    @lablnet
    MemberAuthor

    @peter279k Yes but this approach has few drawbacks

    Using the scheduler.php to let this program run on every minute

    First if any developer want to set schedule to set for 30 seconds then what result expected?

    Also i think this make framework slightly slower

    How can we execute scheduler.php on every mints, without task scheduler or cron?

    The approach i think
    there should be four files

    • AbstractScheduler.php => expression parser
    • Cron.php => Crons commands {extend AbstractScheduler}
    • Schedule.php => Task Scheduler {extend AbstractScheduler}
    • Scheduler.php => Scheduler which use {Cron or Schedule}
      Both class Cron and Schedule should have same methods
      we can do following in Scheduler,php
    namespace Zest\Scheduler;
    
    class Scheduler
    {
          public function __construct()
         {
               $this->scheduler = php_os() === 'win' ? new Schedule() : new Cron();
         }
    }

    What do you think?

  6. peter279k commented on Mar 24, 2019

    @peter279k
    Member
  7. lablnet commented on Mar 24, 2019

    @lablnet
    MemberAuthor

    Sure, so we can start before started actual development it good to write Contracts First
    it let me to starts write schedule.php part
    so you can write Contracts/Interfaces and pull here => https://github.com/zestframework/Zest_Framework/tree/master/src/Contracts
    with sub folder

    the interface name should same as class
    we can use somthing like
    `use \Zest\Contracts\Sitemap\SItemapIndex as SitemapIndexContract``

  8. pinned this issue on Mar 24, 2019
  9. peter279k commented on Mar 24, 2019

    @peter279k
    Member

    @lablnet, consider following code:

    $jobs = [
        [new CronExpression('cron job time'), new TaskName()],
        [new CronExpression('cron job time'), new TaskName()],
    ];
    
    $scheduler = new Schedule($jobs);
    $scheduler->run();

    And let the task be interface so that we can let developers follow Task interface to customize the Task class.

    What do you think about that?

  10. lablnet commented on Mar 24, 2019

    @lablnet
    MemberAuthor

    Yes you are right

    but instead of saying CronExpression it better say TaskExpression or SchedulerExpression

  11. unpinned this issue on Sep 29, 2019
  12. pinned this issue on Nov 27, 2020
  13. added a commit that references this issue on Nov 27, 2020
  14. linked a pull request that will close this issuefix for #154 #324on Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions