Skip to content

docs(APP-18550): specify owners and facility managers CSV files - #33

Closed
nitin33singh wants to merge 1 commit into
allthings:masterfrom
nitin33singh:APP-18550-owners-and-facility-managers
Closed

nitin33singh wants to merge 1 commit into
allthings:masterfrom
nitin33singh:APP-18550-owners-and-facility-managers

Conversation

@nitin33singh

@nitin33singh nitin33singh commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Nisaba now accepts owners.csv, ownerRelations.csv, facilityManagers.csv and facilityManagerRelations.csv (VALID_IMPORT_FILENAMES in nisaba/src/config.ts), so the spec lists 16 recognised CSV files.

Summary by CodeRabbit

  • Documentation
    • Expanded the data exchange specification to cover four additional CSV formats for owners, facility managers, and their relations.
    • Documented required and optional fields, association rules, replacement behavior, and examples for each format.

Nisaba now accepts owners.csv, ownerRelations.csv, facilityManagers.csv
and facilityManagerRelations.csv (VALID_IMPORT_FILENAMES in
nisaba/src/config.ts), so the spec lists 16 recognised CSV files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The specification now covers 16 CSV files. It adds formats for owner and facility-manager records and their relations, with field requirements, examples, and rules for linking each resource to a property, group, or unit.

Changes

Owner and Facility-Manager Formats

Layer / File(s) Summary
Owner and facility-manager records
erp-data-exchange-specification.md
The CSV inventory adds four formats. The owner and facility-manager record specifications define supported operations, required IDs and names, optional contact and address fields, and examples.
Owner and facility-manager relations
erp-data-exchange-specification.md
The relation specifications describe insert rows for linking records to properties, groups, or units. Each resource can have at most one respective relation, and a new link replaces the current one.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: dmitrymarkov

Merge Risk: Low · up to 41dd8

The specification contains two broken navigation links; correcting them is a small documentation fix before merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant