Skip to content

ci(core-sync): use the shared core-sync scripts and workflows - #53

Draft
pimlock wants to merge 3 commits into
mainfrom
feat/shared-core-sync/pimlock
Draft

pimlock wants to merge 3 commits into
mainfrom
feat/shared-core-sync/pimlock

Conversation

@pimlock

@pimlock pimlock commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Draft: switches this repository to the shared core-sync scripts and workflows from ai-openshell/workflows#3, to get a sense of how it looks.

Changes

  • scripts/core-sync/ and scripts/release/tag-release.sh are gone. The core:* and release:tag tasks run the shared scripts through scripts/core-sync.sh, a copy of the shared entry point.
  • core-watch.yml, core-drift.yml, and the tag job of release.yml call the shared reusable workflows at one commit, with no secrets passed (the shared jobs read the sdk-bot environment). That commit is the only pin: the shared workflows run their own commit's scripts, and scripts/core-sync.sh reads the commit from core-drift.yml for local runs.
  • release.yml keeps build and publish.
  • Dependabot groups the three ai-openshell/workflows refs so they move together.
  • New parts of the contract: proto:buf, core:uncovered-rpcs (scripts/uncovered-rpcs.sh, the gRPC stub parsing that was in drift-check.sh) and OPENSHELL_GENERATED_PATHS.
  • The shared drift check runs check before test, so a type error in bindings from core main fails it.
  • CI runs scripts/core-sync.sh --check-pin: the shared workflows must be called at one full SHA on ai-openshell/workflows main, which rejects a pin to a fork-only commit. The shared core-watch also keeps the bot token away from dependency install scripts while it regenerates.

Pins pimlock/workflows until ai-openshell/workflows#3 merges; then the three uses: lines move to a commit on ai-openshell/workflows main. Until then the pin check fails CI on purpose, and local runs need CORE_SYNC_ALLOW_UNMERGED=1.

Testing

  • mise run core:drift passes against core main 90e34ad, with the scripts downloaded through scripts/core-sync.sh
  • core:tags, core:bump -- <tag> --dry-run and release:tag -- --dry-run work
  • workflow lint passes
  • The shared workflows haven't run in CI yet

Replace the core-sync scripts and tag-release.sh with mise remote tasks
pinned to ai-openshell/workflows, and turn core-watch.yml and
core-drift.yml into callers of the shared reusable workflows. The release
workflow tags through the shared release:tag task.

This repository keeps the language-specific parts the shared scripts
call: proto:buf, core:uncovered-rpcs (gRPC stub parsing) and
OPENSHELL_GENERATED_PATHS. The shared drift check also runs check before
test, so a type error in bindings from core main now fails it.

Draft: pins pimlock/workflows until the shared PR merges.
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
The shared workflows now run the scripts of their own commit, so the
mise remote tasks and their second ref go. scripts/core-sync.sh runs the
scripts from CORE_SYNC_DIR in CI and, locally, from the commit that
core-drift.yml calls. The release tag job calls the shared
release-tag.yml at the same commit, and Dependabot groups the three
workflow refs.

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Update scripts/core-sync.sh and the pin to the hardened shared
workflows. CI now runs scripts/core-sync.sh --check-pin: the shared
workflows must be called at one full commit SHA that is on
ai-openshell/workflows main, so a pin to a fork-only commit fails. Until
the shared PR merges, the pin is on pimlock/workflows and this check
fails on purpose; local runs need CORE_SYNC_ALLOW_UNMERGED=1.

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant