Repository navigation
Conversation
Replace the core-sync scripts and tag-release.sh with mise remote tasks pinned to ai-openshell/workflows, and turn core-watch.yml and core-drift.yml into callers of the shared reusable workflows. The release workflow tags through the shared release:tag task. This repository keeps the language-specific parts the shared scripts call: proto:buf, core:uncovered-rpcs (gRPC stub parsing) and OPENSHELL_GENERATED_PATHS. The shared drift check also runs check before test, so a type error in bindings from core main now fails it. Draft: pins pimlock/workflows until the shared PR merges. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
The shared workflows now run the scripts of their own commit, so the mise remote tasks and their second ref go. scripts/core-sync.sh runs the scripts from CORE_SYNC_DIR in CI and, locally, from the commit that core-drift.yml calls. The release tag job calls the shared release-tag.yml at the same commit, and Dependabot groups the three workflow refs. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Update scripts/core-sync.sh and the pin to the hardened shared workflows. CI now runs scripts/core-sync.sh --check-pin: the shared workflows must be called at one full commit SHA that is on ai-openshell/workflows main, so a pin to a fork-only commit fails. Until the shared PR merges, the pin is on pimlock/workflows and this check fails on purpose; local runs need CORE_SYNC_ALLOW_UNMERGED=1. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft: switches this repository to the shared core-sync scripts and workflows from ai-openshell/workflows#3, to get a sense of how it looks.
Changes
scripts/core-sync/andscripts/release/tag-release.share gone. Thecore:*andrelease:tagtasks run the shared scripts throughscripts/core-sync.sh, a copy of the shared entry point.core-watch.yml,core-drift.yml, and the tag job ofrelease.ymlcall the shared reusable workflows at one commit, with no secrets passed (the shared jobs read thesdk-botenvironment). That commit is the only pin: the shared workflows run their own commit's scripts, andscripts/core-sync.shreads the commit fromcore-drift.ymlfor local runs.release.ymlkeeps build and publish.ai-openshell/workflowsrefs so they move together.proto:buf,core:uncovered-rpcs(scripts/uncovered-rpcs.sh, the gRPC stub parsing that was indrift-check.sh) andOPENSHELL_GENERATED_PATHS.checkbeforetest, so a type error in bindings from coremainfails it.scripts/core-sync.sh --check-pin: the shared workflows must be called at one full SHA onai-openshell/workflowsmain, which rejects a pin to a fork-only commit. The sharedcore-watchalso keeps the bot token away from dependency install scripts while it regenerates.Pins
pimlock/workflowsuntil ai-openshell/workflows#3 merges; then the threeuses:lines move to a commit onai-openshell/workflowsmain. Until then the pin check fails CI on purpose, and local runs needCORE_SYNC_ALLOW_UNMERGED=1.Testing
mise run core:driftpasses against coremain90e34ad, with the scripts downloaded throughscripts/core-sync.shcore:tags,core:bump -- <tag> --dry-runandrelease:tag -- --dry-runwork