Repository navigation
Conversation
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep SSH session credentials out of the process arguments used for sandbox connections, file transfers and port forwards.
What changed
The invoking CLI or TUI requests the session using its existing gateway client. OpenSSH receives a one-use local handle. The proxy reads the grant over a same-account Unix socket or Windows named pipe and uses it to open the authenticated relay. The issuer attempts revocation after relay admission, failed handoff or cancellation. File operations keep the selected sandbox identity across retries and across uploads in one create request. Existing name-based OpenSSH configuration continues to work.
Scope
An explicit
--gatewaynow takes precedence overOPENSHELL_GATEWAY_ENDPOINTinherited from the environment. A deliberately supplied endpoint override remains available. Regenerate custom proxy commands that passed the old hidden--tokenoption. On Unix the proxy checks the account of the socket peer and the issuer PID. The Windows named pipe restricts access to the issuing account. Revocation is best effort if the issuer dies or the gateway is unavailable.Verification
--locked.