Repository navigation
Conversation
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. api-behavior — No explicit risk acceptance foundQualification-summary publication moves from ghcr.io/nvidia/openshell/qualification to ghcr.io/ai-openshell/openshell/qualification without retaining the documented endpoint.
Review details
Advisory review; publication gates are unchanged. |
SDAChess
marked this pull request as ready for review
November 20, 2026 13:40
SDAChess
requested review from
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 20, 2026 14:06
The moved repository's token cannot push to ghcr.io/nvidia/openshell. Build the CI job image and the SHA-tagged gateway, sandbox and supervisor E2E images under ghcr.io/ai-openshell/openshell, and pull them from there in the E2E lanes, tmachine input preparation and release qualification. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
The E2E harness falls back to ghcr.io/nvidia/openshell for SHA-tagged CI images, which the moved repository no longer publishes. Point the Docker, Podman and Kubernetes harness defaults, the TESTING.md variable table and the test-guest cache example at ghcr.io/ai-openshell/openshell. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
The moved repository cannot pull the internal ghcr.io/nvidia/openshell/ci package. Pin every job container to the CI image built in the new home, ghcr.io/ai-openshell/openshell/ci, by digest. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
force-pushed
the
ci/4554-ci-registry/SDAChess
branch
from
November 20, 2026 14:15
82e753b to
f86a84e
Compare
alangou
approved these changes
Nov 20, 2026
SDAChess
added this pull request to the merge queue
Nov 20, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the transfer to
ai-openshell/openshell, the repository token cannot push to or pull fromghcr.io/nvidia/openshell, andghcr.io/nvidia/openshell/ciis an internal NVIDIA package. This PR moves the CI registry toghcr.io/ai-openshell/openshellso CI builds and pulls its images in the new org.Draft until the transfer. It merges right after the transfer, ahead of other PRs, because Branch Checks and Helm Lint fail everywhere until it lands.
Related Issue
Refs #4554
Changes
ci-image.ymlpushes the CI job image toghcr.io/ai-openshell/openshell/ci.build-docker-imagetags the gateway, sandbox and supervisor E2E images and verifies their SBOMs under the new registry.setup-e2e-kind,prepare-integration-inputsandrelease-qualificationpull from the new registry.To follow on this branch after the transfer:
ci-image.ymlon this branch to publish the firstghcr.io/ai-openshell/openshell/ciimage.openshell/cipackage public; fork PR runs pull it without credentials.ghcr.io/nvidia/openshell/ci(Branch Checks, Helm Lint, cargo-deny, Release Dev, Release VM Kernel, the disabled GPU E2E) to the new image by digest.With step 3 in place, this PR's own required checks can pass. If it has to merge before step 3, it needs a maintainer bypass, because its jobs cannot pull the old image from the new org.
Release promotion references to
ghcr.io/nvidia/openshell(release-dev,release-publish,release-helm-oci,release-canary,prepare-upgrade-source) and the E2E script registry defaults are handled in separate PRs.Testing
mainChecklist