Skip to content

ci(e2e): run the Podman external-driver conformance on tmachine - #5813

Draft
elezar wants to merge 3 commits into
ai-openshell:mainfrom
elezar:ci/tmachine-external-podman-driver/elezar
Draft

elezar wants to merge 3 commits into
ai-openshell:mainfrom
elezar:ci/tmachine-external-podman-driver/elezar

Conversation

@elezar

@elezar elezar commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Run the Podman compute driver as an external service next to the packaged gateway on tmachine, for both rootful and rootless Podman, and make the external driver role runtime-agnostic so Docker and Podman share one scheme.

Related Issue

No issue of its own. This follows #5602, which added the Docker external-driver lane, under the driver extraction tracked in #5200. The new tmachine rows replace the shell-driven podman-external-driver-e2e lane, which this PR removes.

Changes

  • The openshell_external_driver role reads each runtime's driver arguments, environment and optional config template from vars/<runtime>.yaml, instead of assuming the Docker driver's flags.
  • New vars/podman.yaml: the driver runs as the gateway's user (root for rootful, tmachine for rootless). Rootless sets XDG_RUNTIME_DIR and waits for the user's manager, since its Podman socket is a user unit.
  • config.nix builds the external-driver installers with one helper. deb-external-docker-driver is unchanged. rpm-external-podman-driver is new and serves both Podman environments, because the role selects settings from the machine's runtime.
  • e2e-suites.yml has conformance rows for fedora-podman-rootful and fedora-podman-rootless with the new installer.
  • Remove podman-external-driver-e2e, its e2e:podman:external-driver task, and the external-driver-binary input of e2e-podman-test.yml, which only it used. The OPENSHELL_E2E_EXTERNAL_COMPUTE_DRIVER branches in e2e/with-podman-gateway.sh are now unused and are left for a follow-up.
  • Staging needs no change: the integration inputs already download openshell-driver-* and build-external-drivers already builds the Podman driver.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checked locally on macOS: the tmachine nix config evaluates with stubbed packages and yields the expected installers, the role's service template renders for Docker, rootful Podman and rootless Podman, ansible-playbook --syntax-check passes, and the SPDX header check passes. Not run: a tmachine/QEMU session, so the new rows are unproven on a guest until CI runs them.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Each runtime's vars file now supplies the driver's own arguments, environment,
and an optional configuration template, so the service template no longer
assumes the Docker driver's flags. Add the Podman settings, which run the
driver as the gateway's user and wait for the rootless user manager.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Build the external-driver installers from one helper and add
rpm-external-podman-driver, which serves both rootful and rootless Podman
because the role selects the driver's settings from the machine's runtime.
Add conformance rows for both Fedora Podman environments.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 20, 2026
@elezar elezar added the test:e2e Requires end-to-end coverage label Nov 20, 2026
@elezar

elezar commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

/ok-to-test ad7722e

@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/5813 does not exist yet. A maintainer needs to comment /ok to test ad7722ea7271bd9130b1e6e5d3bde0af19228df8 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

The tmachine rows for rpm-external-podman-driver run the same Podman
conformance against the packaged gateway, so drop podman-external-driver-e2e,
its mise task, and the external-driver-binary input only it used.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar

elezar commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

/ok-to-test 378252e

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant