Repository navigation
Conversation
Each runtime's vars file now supplies the driver's own arguments, environment, and an optional configuration template, so the service template no longer assumes the Docker driver's flags. Add the Podman settings, which run the driver as the gateway's user and wait for the rootless user manager. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Build the external-driver installers from one helper and add rpm-external-podman-driver, which serves both rootful and rootless Podman because the role selects the driver's settings from the machine's runtime. Add conformance rows for both Fedora Podman environments. Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok-to-test ad7722e |
|
Label |
The tmachine rows for rpm-external-podman-driver run the same Podman conformance against the packaged gateway, so drop podman-external-driver-e2e, its mise task, and the external-driver-binary input only it used. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Contributor
Author
|
/ok-to-test 378252e |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the Podman compute driver as an external service next to the packaged gateway on tmachine, for both rootful and rootless Podman, and make the external driver role runtime-agnostic so Docker and Podman share one scheme.
Related Issue
No issue of its own. This follows #5602, which added the Docker external-driver lane, under the driver extraction tracked in #5200. The new tmachine rows replace the shell-driven
podman-external-driver-e2elane, which this PR removes.Changes
openshell_external_driverrole reads each runtime's driver arguments, environment and optional config template fromvars/<runtime>.yaml, instead of assuming the Docker driver's flags.vars/podman.yaml: the driver runs as the gateway's user (root for rootful,tmachinefor rootless). Rootless setsXDG_RUNTIME_DIRand waits for the user's manager, since its Podman socket is a user unit.config.nixbuilds the external-driver installers with one helper.deb-external-docker-driveris unchanged.rpm-external-podman-driveris new and serves both Podman environments, because the role selects settings from the machine's runtime.e2e-suites.ymlhas conformance rows forfedora-podman-rootfulandfedora-podman-rootlesswith the new installer.podman-external-driver-e2e, itse2e:podman:external-drivertask, and theexternal-driver-binaryinput ofe2e-podman-test.yml, which only it used. TheOPENSHELL_E2E_EXTERNAL_COMPUTE_DRIVERbranches ine2e/with-podman-gateway.share now unused and are left for a follow-up.openshell-driver-*andbuild-external-driversalready builds the Podman driver.Testing
Checked locally on macOS: the tmachine nix config evaluates with stubbed packages and yields the expected installers, the role's service template renders for Docker, rootful Podman and rootless Podman,
ansible-playbook --syntax-checkpasses, and the SPDX header check passes. Not run: a tmachine/QEMU session, so the new rows are unproven on a guest until CI runs them.Checklist