Repository navigation
Conversation
The ai-openshell organization enforces sign-off on every repository with the DCO app, which checks each commit for a Signed-off-by trailer. Remove the contributor-assistant workflow that duplicated it with a one-time PR comment signature, and update CONTRIBUTING.md and CI.md to describe the per-commit check. The DCO file stays. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ai-openshell organization enforces sign-off with the DCO app on every repository, which duplicates core's DCO Assistant workflow. This removes the workflow.
Merge after the transfer. The DCO app is not installed on NVIDIA/OpenShell, so merging earlier leaves core with no DCO check.
Related Issue
Refs #4554
Changes
.github/workflows/dco.ymland its zizmor suppression. TheDCOfile stays; CONTRIBUTING.md and the CNCF project metadata link to it.Signed-off-by.CONTRIBUTING.mdnow says so and how to fix a failing PR.CONTRIBUTING.mdandCI.md: Dependabot commits already carrySigned-off-by: dependabot[bot].The
signaturesbranch (dco-signatures.json) and thetest/dco-workflow-verifybranch existed only for this workflow and can be deleted after merge. If a ruleset requires theDCOAssistantcheck, replace it with the DCO app's check.Release Notes
Testing
actionlintandzizmor --min-severity=highreport the same findings asmain.Checklist