Skip to content

ci: remove the DCO Assistant workflow - #5805

Draft
SDAChess wants to merge 1 commit into
mainfrom
ci/4554-remove-dco-assistant/SDAChess
Draft

SDAChess wants to merge 1 commit into
mainfrom
ci/4554-remove-dco-assistant/SDAChess

Conversation

@SDAChess

Copy link
Copy Markdown
Contributor

Summary

The ai-openshell organization enforces sign-off with the DCO app on every repository, which duplicates core's DCO Assistant workflow. This removes the workflow.

Merge after the transfer. The DCO app is not installed on NVIDIA/OpenShell, so merging earlier leaves core with no DCO check.

Related Issue

Refs #4554

Changes

  • Delete .github/workflows/dco.yml and its zizmor suppression. The DCO file stays; CONTRIBUTING.md and the CNCF project metadata link to it.
  • Behavior change for contributors: DCO Assistant accepted a one-time "I have read the DCO document and I hereby sign the DCO." PR comment and never checked commit trailers. The DCO app checks every commit for Signed-off-by. CONTRIBUTING.md now says so and how to fix a failing PR.
  • Drop the Dependabot allowlist notes from CONTRIBUTING.md and CI.md: Dependabot commits already carry Signed-off-by: dependabot[bot].

The signatures branch (dco-signatures.json) and the test/dco-workflow-verify branch existed only for this workflow and can be deleted after merge. If a ruleset requires the DCOAssistant check, replace it with the DCO app's check.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass: actionlint and zizmor --min-severity=high report the same findings as main.
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

The ai-openshell organization enforces sign-off on every repository with
the DCO app, which checks each commit for a Signed-off-by trailer. Remove
the contributor-assistant workflow that duplicated it with a one-time PR
comment signature, and update CONTRIBUTING.md and CI.md to describe the
per-commit check. The DCO file stays.

Refs #4554

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant