Repository navigation
fix(install): resolve releases from ai-openshell/openshell - #5801
Merged
Merged
Conversation
5 of 7 tasks
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. cli — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
alangou
approved these changes
Nov 20, 2026
SDAChess
enabled auto-merge
November 20, 2026 14:00
The repository moved to ai-openshell/openshell. GitHub redirects the old releases/latest URL to the new location, which the installer rejected as an unexpected redirect target. Point REPO at the new name. Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
force-pushed
the
fix/4554-install-sh-redirect-guard/SDAChess
branch
from
November 20, 2026 14:06
c6d108b to
c907982
Compare
SDAChess
disabled auto-merge
November 20, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point
install.shatai-openshell/openshell. After the transfer, GitHub redirectsgithub.com/NVIDIA/OpenShell/releases/latestto the new location, and the installer's redirect check (derived fromREPO) rejects it with "unexpected redirect target". Every install withoutOPENSHELL_VERSIONfails until this lands.Important
Do not merge before the transfer.
ai-openshell/openshelldoes not exist until then, so every install would fail. Merge immediately after the transfer.Related Issue
Refs #4554
Changes
install.sh:REPO="ai-openshell/openshell".tasks/scripts/test-install-sh.sh: expectedgh run download --repovalue.Every step that resolves or downloads a release derives from
REPOorGITHUB_URL:/releases/latestand its redirect check,gh api repos/${REPO}/...,gh run download --repo, the asset, package andopenshell.rbURLs. Nothing else in that path names the old repo.The usage text,
release.py, workflows and other tooling move in a stacked follow-up so this diff stays small.Known gap until the follow-up lands and a new prerelease is cut: on macOS,
OPENSHELL_VERSION=prepatches the prerelease formula's URLs by exact match againstGITHUB_URL, and formulas generated under the old name will not match. Stable,devand Linux installs are unaffected.Testing
tasks/scripts/test-install-sh.shpasses.Checklist