Skip to content

fix(install): resolve releases from ai-openshell/openshell - #5801

Merged
alangou merged 1 commit into
mainfrom
fix/4554-install-sh-redirect-guard/SDAChess
Nov 20, 2026
Merged

alangou merged 1 commit into
mainfrom
fix/4554-install-sh-redirect-guard/SDAChess

Conversation

@SDAChess

Copy link
Copy Markdown
Contributor

Summary

Point install.sh at ai-openshell/openshell. After the transfer, GitHub redirects github.com/NVIDIA/OpenShell/releases/latest to the new location, and the installer's redirect check (derived from REPO) rejects it with "unexpected redirect target". Every install without OPENSHELL_VERSION fails until this lands.

Important

Do not merge before the transfer. ai-openshell/openshell does not exist until then, so every install would fail. Merge immediately after the transfer.

Related Issue

Refs #4554

Changes

  • install.sh: REPO="ai-openshell/openshell".
  • tasks/scripts/test-install-sh.sh: expected gh run download --repo value.

Every step that resolves or downloads a release derives from REPO or GITHUB_URL: /releases/latest and its redirect check, gh api repos/${REPO}/..., gh run download --repo, the asset, package and openshell.rb URLs. Nothing else in that path names the old repo.

The usage text, release.py, workflows and other tooling move in a stacked follow-up so this diff stays small.

Known gap until the follow-up lands and a new prerelease is cut: on macOS, OPENSHELL_VERSION=pre patches the prerelease formula's URLs by exact match against GITHUB_URL, and formulas generated under the old name will not match. Stable, dev and Linux installs are unaffected.

Testing

  • tasks/scripts/test-install-sh.sh passes.
  • Not verified against the real repository, which does not exist until the transfer.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 20, 2026
@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. cli — No explicit risk acceptance found

OPENSHELL_VERSION=pre sh install.sh previously rewrote NVIDIA/OpenShell formula URLs to local artifacts, but now matches only ai-openshell/openshell while generated formulas still use NVIDIA/OpenShell.

  • Impact: Apple Silicon macOS installations using pre or an explicit prerelease tag leave remote URLs intact, causing Homebrew to request nonexistent GitHub Release assets instead of using the downloaded packages.
  • Action: For v0.1.10, rewrite both repository URL prefixes to local artifacts so existing retained prereleases remain installable rather than relying on a follow-up and newly generated packages.
  • PR: fix(install): resolve releases from ai-openshell/openshell #5801
Review details
  • Execution: complete
  • Candidate: PR #5801 (450f969219310c8dea986674cbe5692ea96e6a5b)
  • Baseline: 498a0bb3eb92ae1a60ec459e12ce4657b8ee6af2 (498a0bb3eb92ae1a60ec459e12ce4657b8ee6af2)
  • Reviewed: rust-sdk, python-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

@SDAChess
SDAChess enabled auto-merge November 20, 2026 14:00
The repository moved to ai-openshell/openshell. GitHub redirects the old
releases/latest URL to the new location, which the installer rejected as
an unexpected redirect target. Point REPO at the new name.

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@SDAChess
SDAChess force-pushed the fix/4554-install-sh-redirect-guard/SDAChess branch from c6d108b to c907982 Compare November 20, 2026 14:06
@SDAChess
SDAChess disabled auto-merge November 20, 2026 14:12
@alangou
alangou merged commit 186e006 into main Nov 20, 2026
111 of 168 checks passed
@alangou
alangou deleted the fix/4554-install-sh-redirect-guard/SDAChess branch November 20, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants