Skip to content

test(e2e): port gateway-configuration tests that need no restart to feature suites - #5792

Draft
matthewgrossman wants to merge 24 commits into
test/5728-share-environment-helpers/matthewgrossmanfrom
test/5729-port-gateway-config-tests/matthewgrossman
Draft

matthewgrossman wants to merge 24 commits into
test/5728-share-environment-helpers/matthewgrossmanfrom
test/5729-port-gateway-config-tests/matthewgrossman

Conversation

@matthewgrossman

Copy link
Copy Markdown
Member

Summary

Port the #5729 gateway-configuration tests that need no gateway restart from e2e/rust to testkit feature suites, and remove the legacy tests and their wrapper wiring. Each suite runs on a tmachine environment that sets the gateway configuration it needs, so no test edits gateway config.

This stacks on #5780 (#5728).

Related Issue

Closes #5729
Part of #5281

Changes

  • features/provider-refresh: the refresh-managed credential handle test. Adds provider refresh commands to the testkit context and uses them in keycloak-provider-refresh too.
  • features/otlp-relay: the agent trace relay tests, with an OTLP collector fixture in tests/support and a fedora-podman-rootless-otlp environment that points the gateway at it.
  • features/provider-token-exchange: the SPIFFE token exchange tests, with a SPIFFE Workload API fixture in tests/support and SPIFFE environments.
  • features/provider-rotation: provider_readiness and stable_external_placeholders. The TLS servers now run on the test host, signed by a new additional-CA environment (<base>-additional-ca). Before, they ran in containers on the e2e network, with a supervisor image rebuilt to trust their CA. The wrong-host checks use the host's primary IPv4 address, and the tests check that it differs from the address host.openshell.internal reaches.
  • e2e-suites.yml: rows for the new suites, plus an optional per-row filter (a nextest filterset). It lets the inert OTLP test run on ubuntu-docker-rootful while the collector tests run on fedora-podman-rootless-otlp.
  • e2e/rust: removes the five legacy tests, their [[test]] entries and dependencies, the PODMAN_CI_TESTS entries, and the SPIFFE and OTLP wiring in the Docker and Podman wrappers.

Pending

Driver coverage

Test Before Now
provider refresh handle Podman (full task only) Docker rootful, Podman rootful. Rootless: #5782
OTLP relay, collector Podman Podman rootless
OTLP relay, inert Docker Docker rootful
provider token exchange Podman Podman rootless (SPIFFE)
provider readiness, stable placeholders Docker Docker rootful, Podman rootful (additional CA)

Testing

Each suite ran locally through openshell-test-runner on tmachine:

  • provider-refresh: 3/3 on ubuntu-docker-rootful/deb and fedora-podman-rootful/rpm
  • provider-rotation: 3/3 on ubuntu-docker-rootful-additional-ca/deb and fedora-podman-rootful-additional-ca/rpm (one more Podman run never started because of a VM SSH login failure)
  • otlp-relay: collector tests on fedora-podman-rootless-otlp/rpm, inert test on ubuntu-docker-rootful/deb
  • provider-token-exchange: fedora-podman-rootless-spiffe/rpm

Also run: cargo fmt --check and cargo clippy --all-targets --locked -D warnings for the root, tests/support and tests/suites/features workspaces; cargo test in tests/support; cargo check of e2e/rust with the Docker and Podman features; tasks/scripts/test-gateway-config.sh; check_cargo_lockfile_alignment.py.

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…settings

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
… in keycloak-provider-refresh

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…ay at a test collector

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…ress

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…ers/matthewgrossman' into test/5729-port-gateway-config-tests/matthewgrossman

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 20, 2026
@matthewgrossman
matthewgrossman force-pushed the test/5728-share-environment-helpers/matthewgrossman branch from d1cf453 to 8005863 Compare November 20, 2026 05:50
…ers/matthewgrossman' into test/5729-port-gateway-config-tests/matthewgrossman

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

# Conflicts:
#	TESTING.md
#	tests/support/README.md
#	tests/support/host-server/src/http.rs
#	tests/support/host-server/src/tls.rs
#	tests/tmachine/ansible/playbooks/drivers/podman/userns.yaml
#	tests/tmachine/ansible/roles/gateway_overrides/defaults/main.yaml
#	tests/tmachine/ansible/roles/gateway_overrides/tasks/main.yaml
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@matthewgrossman matthewgrossman added the test:e2e Requires end-to-end coverage label Nov 20, 2026
@matthewgrossman

Copy link
Copy Markdown
Member Author

/ok to test 4b82ab0

@github-actions

Copy link
Copy Markdown

Label test:e2e applied for 4b82ab0. Open Branch E2E Checks, find the run for commit 4b82ab0, and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

…the Podman archive filter

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@matthewgrossman

Copy link
Copy Markdown
Member Author

/ok to test 702e06f

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant