Repository navigation
test(testkit): support per-environment skips in all suites - #5789
Open
matthewgrossman wants to merge 4 commits into
Open
matthewgrossman wants to merge 4 commits into
matthewgrossman wants to merge 4 commits into
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Allow nextest to run zero tests when the environment has unsupported entries. This also allows an empty filter match in that case, but avoids a second archive extraction and test discovery. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
marked this pull request as ready for review
November 20, 2026 05:28
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 20, 2026 05:28
Member
Author
|
/ok to test 91fc8b7 |
|
Label |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feature and driver suites now honor
OPENSHELL_TEST_UNSUPPORTED, so tests can stay in CI rows even when a specific environment can't pass them yet.Related Issue
Closes #5788
Changes
testkit::main(), with unique target names and unchanged nextest package selection. Keep the macro'scfg(test)wrapper for in-flight ports; removing it stays with test(testkit): run every testkit suite as one program, and let nextest run the prebuilt program #5765.tests/suites/unsupported.yamland its reader across all families. Log issue URLs on nextest rows and document how to add entries in the testkit README.For new feature or driver suites, copy these five lines: the first four go in
Cargo.toml(choose a globally unique target name), and rustfmt expands the last line in the test file.Testing
cargo fmt --checkand Clippy (--all-targets -- -D warnings) for features, Podman and conformance; ShellCheck and actionlint for the changed scripts and workflow.check-conformance-program.shpassed with the checked-in list and with temporary entries for all three families. Verified CDI showsSKIPand conformance lists the issue URL. Negative checks rejected an unknown crate, environment and test, an invalid URL, duplicate entries and a missing harness setting.Checklist