Repository navigation
Conversation
Add the openshell_external_driver role and a deb-external-docker-driver installer. The role installs the driver binary and a system service, generates the gateway certificates the driver trusts, waits for its socket, and points the packaged gateway at it through the environment gateway overrides. The packaged gateway role starts it after the runtime images load and before the gateway, and selects it by name; a built-in driver's name cannot be selected over a socket. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Replace the docker-external-driver-e2e lane, which ran the conformance tests against a driver-free gateway and a driver started from a shell wrapper, with a tmachine row that installs the packaged gateway and runs openshell-driver-docker as a service (deb-external-docker-driver). The release workflows share e2e-suites.yml and prepare-integration-inputs.yml but do not build external drivers, so the row and the driver download are opt-in (external-drivers). Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 16, 2026 11:39
elezar
commented
Nov 16, 2026
|
Label |
elezar
force-pushed
the
ci/5602-tmachine-external-docker-driver/elezar
branch
from
November 16, 2026 11:49
282b796 to
acff784
Compare
Contributor
Author
|
/ok-to-test acff784 |
SDAChess
approved these changes
Nov 16, 2026
github-actions
Bot
requested review from
TaylorMutch,
matthewgrossman and
purp
November 16, 2026 14:04
Merged
via the queue into
ai-openshell:main
with commit Nov 16, 2026
bdb8be3
266 of 270 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the Docker compute driver as an external service against the packaged gateway on tmachine, and use that row to replace
docker-external-driver-e2e. The tmachine row exercises the packaged gateway, its service and its TLS setup; the old lane used a driver-free gateway and a driver started from a shell wrapper.Related Issue
Closes #5602
Changes
openshell_external_driverrole, which installs a driver binary and a system service, generates the gateway certificates the driver trusts, waits for its socket, and points the gateway at it through/etc/openshell-test/gateway-overrides.toml.gateway.envselects it by name. Built-in driver names can't be selected over a socket, so the driver registers asexternal.deb-external-docker-driverinstaller.build-external-driversbuildsopenshell-driver-dockerfor x86_64, andprepare-integration-inputs.ymlcopies it into the tmachine inputs. The newexternal-driversinput onprepare-integration-inputs.ymlande2e-suites.ymlis opt-in becauserelease-devandrelease-qualificationshare those workflows and don't build external drivers.ubuntu-docker-rootful+deb-external-docker-driverconformance row, enabled frombranch-e2e.yml.docker-external-driver-e2e,e2e:docker:external-driver, theexternal-driver-binaryinput ofe2e-docker-test.yml, and the external-driver branches ofe2e/with-docker-gateway.shanddocker_corporate_proxy.rs. The Podman, VM and Kubernetes external-driver lanes are unchanged.Release Notes
Testing
Run locally on an arm64 host (aarch64 guest):
openshell-test-runner run --environment ubuntu-docker-rootful --installer deb-external-docker-driver --family conformance --gateway openshell: 36 of 36 conformance tests passed.mise run license:check,mise run rust:format:checkandcargo check --testsfore2e/rustpass. The workflow YAML parses,bash -n e2e/with-docker-gateway.shpasses, and the matrix filter ine2e-suites.ymlincludes the new row only whenexternal-driversis true.Not run: the GitHub Actions workflows themselves (amd64, KVM runners) and the in-process Docker e2e after the
with-docker-gateway.shedit. The conformance suite was intermittently flaky on the local VM (both with and without the external driver), and the runner's SSH step occasionally rejected the guest password right after a layer build; a rerun on the cached layer passed.Checklist