Skip to content

aem aio-aem-events-osgi-mapping Need fine grain control on AEM events that which path to send event to Adobe IO and support regex expression #124

Open

Description

@shehjad-khan

Expected Behaviour

The OSGI configuration present in AEM should support regex filter path and thus in my case use case is to send events to adobe IO only when asset uploaded in AEM is of type PDF.

For this Adobe I/O Events' OSGI Event Mapping should support regex expression in OSGI JCR Path Filter Field

image

Actual Behaviour

In this specific use cases only event should only be passed from AEM when the path matches the regex expression

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

https://github.com/adobe/aio-lib-java/blob/main/aem/events_osgi_mapping/src/main/java/com/adobe/aio/aem/event/osgimapping/eventhandler/AdobeIoEventHandler.java#L118

Above code needs to be changed to support regex rather than just checking startsWith

To support current use case of startsWith
String pdfPath = "/content/dam/daiuyijava.pdf";
String regex = "/content/dam/([^/]+)";
Pattern pt = Pattern.compile(regex) ;
Matcher mt = pt.matcher(pdfPath);
System.out.println(mt.matches());

To support more fine grain cases for example only send event when it is a PDF asset
String pdfPath = "/content/dam/daiuyijava.pdf";
String regex = "/content/dam/([^/]+)+\.(pdf|PDF)";
Pattern pt = Pattern.compile(regex) ;
Matcher mt = pt.matcher(pdfPath);
System.out.println(mt.matches());

Logs taken while reproducing problem

Activity

  1. changed the title [-]Need fine grain control on AEM that which path to send event to Adobe IO and support regex expression[/-] [+]Need fine grain control on AEM events that which path to send event to Adobe IO and support regex expression[/+] on Aug 19, 2022
  2. changed the title [-]Need fine grain control on AEM events that which path to send event to Adobe IO and support regex expression[/-] [+]`aem` `aio-aem-events-osgi-mapping` Need fine grain control on AEM events that which path to send event to Adobe IO and support regex expression[/+] on Aug 23, 2022
  3. francoisledroff commented on Aug 23, 2022

    @francoisledroff
    Collaborator

    we like this idea !
    we'd be happy to review your PR.

  4. shehjad-khan commented on Aug 29, 2022

    @shehjad-khan
    Author

    @francoisledroff Thank you, read the contributors guideline and would love to raise a PR, but would need to be invited to be a committer to the repo with write access on my email shehjkhan@gmail.com. If there is some other process, please point me to the documentation happy to follow it

  5. francoisledroff commented on Sep 7, 2022

    @francoisledroff
    Collaborator

    Thanks @shehjad-khan you actually don't need write access, do the following

    • fork the repo
    • submit a PR from this fork
    • I'll review it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions