Conversation
… in `WP::parse_request()`. When rewrite rules exist, `$error` is set to `'404'` and only cleared once a rule matches. At the point where a matched rule's query is parsed, `$error` therefore always still holds `'404'`, so the `'404' === $error` check around clearing it always passes and is removed. This resolves one error in the `identical.alwaysTrue` PHPStan baseline. See #65817.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
In
WP::parse_request(),$erroris set to'404'on line 167 and is not changed again before the'404' === $errorcheck that clears it once a rewrite rule matches. The check therefore always passes and is removed. There is no change in behavior.This resolves one error in the
identical.alwaysTruePHPStan baseline.Trac ticket: https://core.trac.wordpress.org/ticket/65817
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.