Repository navigation
Conversation
mfishma
commented
Oct 19, 2026
- updated showcase image
- updated generate_langs for maps
- generate_langs min/max version changes to make it easier to run without updating script
- poplar leaves change
924ef20 to
24ac020
Compare
|
A few more changes to prep for v1 integration:
|
Have you tried with Optifine? CIT Resewn wasn't that good back then. |
| files: ViaBackwards-Plus-v1-${{ github.event.inputs.version }}.zip | ||
| loaders: minecraft | ||
| game-versions: "[1.16.2,1.20.4]" | ||
| game-versions: "[1.16.4,1.20.4]" |
There was a problem hiding this comment.
Check whether it works with Optifine, if no we can remove this version I guess, but no is preferred
There was a problem hiding this comment.
It can work, but we have the Chime requirement, which only runs on 1.16.4, so then Curseforge says there's a conflict. And Fabric, too, was only 1.16.4.
And then if we make Chime optional, people may miss it and wonder why things aren't working quite right. Certainly a minor case. Nobody actually plays 1.16.2, I don't think. Maybe the readme can mention it should work with 1.16.2 and optifine?
There was a problem hiding this comment.
I mean nobody will miss it I think, but still it would be better if we wouldn't have to drop support for it. Altho if CF is doing some weird shit with the dependencies than I guess it can go
| "index": 0, | ||
| "entries": [ | ||
| { | ||
| "threshold": 871.0, |
There was a problem hiding this comment.
In modern Minecraft version's can't we use string values instead of numbers?
There was a problem hiding this comment.
Yes we can. Introduced in 24w45a (snapshot for 1.21.4)
There was a problem hiding this comment.
Yep, that's how we got 1.21.4 support going in the first place. I was thinking the new numbers would be more precise and easy to extract, since now they're in the mapping-XXXtoXXX.json files. But you're right, strings are cleaner
And almost all server plugins (ItemsAdder, Oraxen, Paper's setCustomModelData) still assign their data to floats[0] and leave strings alone. and ViaBackwards will just not write to floats if there's already one there, but still appends an identifier to strings, so someone could theoretically just have it check strings[0] and strings[1].
I'll convert the 26.3 items over to select with string cases, we'll use the numbers for v1.
| files: ViaBackwards-Plus-v1-${{ github.event.inputs.version }}.zip | ||
| loaders: minecraft | ||
| game-versions: "[1.16.2,1.20.4]" | ||
| game-versions: "[1.16.4,1.20.4]" |
There was a problem hiding this comment.
I mean nobody will miss it I think, but still it would be better if we wouldn't have to drop support for it. Altho if CF is doing some weird shit with the dependencies than I guess it can go
| chime(required){modrinth:ubxU84eR}{curseforge:432776}#(ignore:github) | ||
| cit-resewn(optional){modrinth:otVJckYQ}{curseforge:521427}#(ignore:github) | ||
| respackopts(optional){modrinth:TiF5QWZY}#(ignore:curseforge,github) | ||
| respackopts(optional){modrinth:TiF5QWZY}{curseforge:430090}#(ignore:github) |
There was a problem hiding this comment.
In #35 you are removing respackopts, do so here as well
/
| chime(required){modrinth:ubxU84eR}{curseforge:432776}#(ignore:github) | ||
| cit-resewn(optional){modrinth:otVJckYQ}{curseforge:521427}#(ignore:github) | ||
| respackopts(optional){modrinth:TiF5QWZY}#(ignore:curseforge,github) | ||
| respackopts(optional){modrinth:TiF5QWZY}{curseforge:430090}#(ignore:github) |
There was a problem hiding this comment.
| respackopts(optional){modrinth:TiF5QWZY}{curseforge:430090}#(ignore:github) |