Skip to content

Update 26.3 (v2) language files - #33

Open
mfishma wants to merge 7 commits into
mainfrom
update/26.3-map-translations
Open

mfishma wants to merge 7 commits into
mainfrom
update/26.3-map-translations

Conversation

@mfishma

@mfishma mfishma commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator
  • updated showcase image
  • updated generate_langs for maps
  • generate_langs min/max version changes to make it easier to run without updating script
  • poplar leaves change

@mfishma
mfishma force-pushed the update/26.3-map-translations branch from 924ef20 to 24ac020 Compare October 20, 2026 10:15
@mfishma

mfishma commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

A few more changes to prep for v1 integration:

  • Removed omenicon/ from the zip-up workflow for v1, since it wasn't clear it still worked and the philosophy of letting defaults for the version just looking like defaults.
  • Could only get the pack to work starting with 1.16.4 (Chime support) whereas CIT wasn't working in 1.16.2.
  • Added CurseForge dependency ID for respackopts as Optional to match Modrinth's Optional recommendation.

@mfishma
mfishma requested a review from bangetto October 22, 2026 22:59
@bangetto

Copy link
Copy Markdown
Member
  • Could only get the pack to work starting with 1.16.4 (Chime support) whereas CIT wasn't working in 1.16.2.

Have you tried with Optifine? CIT Resewn wasn't that good back then.

files: ViaBackwards-Plus-v1-${{ github.event.inputs.version }}.zip
loaders: minecraft
game-versions: "[1.16.2,1.20.4]"
game-versions: "[1.16.4,1.20.4]"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check whether it works with Optifine, if no we can remove this version I guess, but no is preferred

@mfishma mfishma Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can work, but we have the Chime requirement, which only runs on 1.16.4, so then Curseforge says there's a conflict. And Fabric, too, was only 1.16.4.

And then if we make Chime optional, people may miss it and wonder why things aren't working quite right. Certainly a minor case. Nobody actually plays 1.16.2, I don't think. Maybe the readme can mention it should work with 1.16.2 and optifine?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean nobody will miss it I think, but still it would be better if we wouldn't have to drop support for it. Altho if CF is doing some weird shit with the dependencies than I guess it can go

"index": 0,
"entries": [
{
"threshold": 871.0,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In modern Minecraft version's can't we use string values instead of numbers?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can. Introduced in 24w45a (snapshot for 1.21.4)

@mfishma mfishma Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's how we got 1.21.4 support going in the first place. I was thinking the new numbers would be more precise and easy to extract, since now they're in the mapping-XXXtoXXX.json files. But you're right, strings are cleaner
And almost all server plugins (ItemsAdder, Oraxen, Paper's setCustomModelData) still assign their data to floats[0] and leave strings alone. and ViaBackwards will just not write to floats if there's already one there, but still appends an identifier to strings, so someone could theoretically just have it check strings[0] and strings[1].

I'll convert the 26.3 items over to select with string cases, we'll use the numbers for v1.

@ViaVersionAddons ViaVersionAddons deleted a comment from FitchWorks Nov 12, 2026
files: ViaBackwards-Plus-v1-${{ github.event.inputs.version }}.zip
loaders: minecraft
game-versions: "[1.16.2,1.20.4]"
game-versions: "[1.16.4,1.20.4]"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean nobody will miss it I think, but still it would be better if we wouldn't have to drop support for it. Altho if CF is doing some weird shit with the dependencies than I guess it can go

chime(required){modrinth:ubxU84eR}{curseforge:432776}#(ignore:github)
cit-resewn(optional){modrinth:otVJckYQ}{curseforge:521427}#(ignore:github)
respackopts(optional){modrinth:TiF5QWZY}#(ignore:curseforge,github)
respackopts(optional){modrinth:TiF5QWZY}{curseforge:430090}#(ignore:github)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #35 you are removing respackopts, do so here as well
/

chime(required){modrinth:ubxU84eR}{curseforge:432776}#(ignore:github)
cit-resewn(optional){modrinth:otVJckYQ}{curseforge:521427}#(ignore:github)
respackopts(optional){modrinth:TiF5QWZY}#(ignore:curseforge,github)
respackopts(optional){modrinth:TiF5QWZY}{curseforge:430090}#(ignore:github)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
respackopts(optional){modrinth:TiF5QWZY}{curseforge:430090}#(ignore:github)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants