Skip to content

ci: Add proper CoreCLR support, remove Mono from trunk and update architecture setup in CI - #4177

Open
michalChrobot wants to merge 4 commits into
develop-3.x.xfrom
ci/add-coreclr-compatibility
Open

michalChrobot wants to merge 4 commits into
develop-3.x.xfrom
ci/add-coreclr-compatibility

Conversation

@michalChrobot

Copy link
Copy Markdown
Member

Purpose of this PR

This PR resolves few pending CI issues that we have which is:

  1. In trunk x64 architecture for macOS was completely removed and it's now ARM64 only so I addressed this here by specifying architecture per each supported platform that we used (issue was that without that param specified the trunk job tried to use x64 arch which is now nonexistent there). For mobile devices there is a split in build platform architecture and actual mobile platform architecture
  2. I added CoreCLR support for players and worth noting is that is mainly for 6000.7 (coreclr is in preview and you need to specify that you want to use coreclr player) while on trunk the default editor is already coreclr-based + mono is removed so I addressed this here
  3. I also added full configuration to job title so even if we run package tests we know which scripting backend is being used (on trunk it's coreclr while on previous editors is mono)
  4. I changed NetcodeConfig in minimalproject to remove automated bootstrapping as otherwise we get warning --> When running minimalproject I get "[UnifiedBootstrap] Auto-bootstrap is enabled!!! This will break the POC!"

Jira ticket

https://jira.unity3d.com/browse/MTT-16251

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

I will run full set of jobs (weekly) to check if everything works

@michalChrobot michalChrobot changed the title [CI] Add proper CoreCLR support, remove Mono from trunk and update architecture setup in CI ci: Add proper CoreCLR support, remove Mono from trunk and update architecture setup in CI Oct 2, 2026
@michalChrobot michalChrobot self-assigned this Oct 2, 2026
@michalChrobot
michalChrobot marked this pull request as ready for review October 2, 2026 12:24
@u-pr

u-pr Bot commented Oct 2, 2026

Copy link
Copy Markdown

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.


Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:
# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The CI templates add CoreCLR player coverage and explicit Editor architectures, but a scheduled mobile build still has an architecture mismatch.

Reviewed commit 8f9e129

🤖 Helpful? 👍/👎

Comment thread .yamato/project.metafile
standalone: IOS
base: mac
architecture: arm64
architecture: x64

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

The iOS build loops over validation_editors.all, which includes trunk, and the nightly trunk mobile-test group depends on that build. This value makes the downloader request a macOS x64 trunk Editor, but trunk no longer provides one, so the iOS build and its test cannot start. Use the ARM64 macOS build image and architecture: arm64; keep target_architecture: arm64 for the player.

🤖 Helpful? 👍/👎

@codecov-github-com

codecov-github-com Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-3.x.x    #4177   +/-   ##
==============================================
  Coverage          78.19%   78.19%           
==============================================
  Files                153      153           
  Lines              26272    26272           
==============================================
  Hits               20544    20544           
  Misses              5728     5728           
Flag Coverage Δ
NGOv2_project_testproject_ubuntu 76.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
com.unity.netcode.gameobjects 78.19% <ø> (ø)

ℹ️ Need help interpreting these results?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant