Repository navigation
fix(platform): name the failing trigger type in resume-trigger errors [MST-18258] - #1993
Draft
IevgenUiPath wants to merge 1 commit into
Draft
IevgenUiPath wants to merge 1 commit into
IevgenUiPath wants to merge 1 commit into
Conversation
… [MST-18258]
When a resume-trigger handler raises a plain exception, create_trigger
wrapped it as "Failed to create HITL action" for every trigger type, so
Maestro showed the same text whether the failing trigger was a task, a
deep RAG job or an IXP extraction. The wrapper message now names the
trigger type ("Failed to create resume trigger of type DeepRag") and the
detail carries the inner exception type and text, so a message-less
exception no longer renders as an empty detail.
The UiPathFaultedTriggerError pass-through, the handlers and the public
signatures are unchanged. Bumps uipath-platform to 0.3.8.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Jira: MST-18258
Problem
Jira MST-18258: when an agent job faults while creating its resume trigger,
UiPathResumeTriggerCreator.create_triggerwraps every non-UiPathFaultedTriggerErrorexception as"Failed to create HITL action", whatever the trigger type. In production that wrapper message is the only explanation the customer sees:uipath-runtimeturns the faulted-trigger error intoRESUME_TRIGGER_ERROR/ "Resume trigger error" with the wrapper's message as the detail, and Maestro relays that detail. Over the last 30 days this fired on 18 instances (samples20883f43,491c271a,0e1efe28), including cases where the failing trigger was a deep-RAG job, an IXP extraction or a plain exception with an empty message, all shown as the same generic "HITL action" text.Change
create_triggernow determinestrigger_typebefore thetry, so theexcept Exceptionwrapper can name it:"Failed to create resume trigger of type DeepRag"(falls back to"Failed to create resume trigger"if the type could not be determined)."RuntimeError: tasks service unavailable"); a message-less exception keeps its type name instead of rendering as an empty detail.ErrorCategory.SYSTEMandfrom eare kept. TheUiPathFaultedTriggerErrorpass-through, the handlers' logic and all public signatures are unchanged.uipath-platformbumped to 0.3.8 (pyproject + both lock files), per the repo's version-availability check.Tests
New tests in
packages/uipath-platform/tests/services/test_hitl.py:UiPathFaultedTriggerErrorraised by a handler is re-raised unchanged (same object, category, message, detail)Run from
packages/uipath-platform(uv, Python 3.11.18):uv sync --locked --all-extrasuv run pytest-> 2094 passed, 7 skipped (credential-gated LLM integration tests), 4 deselected (e2e)uv run ruff check .-> All checks passeduv run ruff format --check .-> 237 files already formatteduv run mypy --config-file pyproject.toml .-> Success: no issues found in 237 source filesOut of scope
The individual root causes behind the instances (a missing context-grounding index, a
StopIterationduring task creation) are not addressed here; this PR only makes the surfaced error say which trigger failed and why.🤖 Generated with Claude Code