Skip to content

feat(memory): [1/3] add fieldMatching to memory search settings [ECS-2116] - #1943

Merged
pateljay43 merged 2 commits into
mainfrom
feat/memory-field-matching
Oct 15, 2026
Merged

pateljay43 merged 2 commits into
mainfrom
feat/memory-field-matching

Conversation

@pateljay43

@pateljay43 pateljay43 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Memory search matched when any one configured field passed its threshold, so an escalation saved for one customer could be recalled for another. ECS now accepts settings.fieldMatching with values or/and, default or (UiPath/vdbs#2882). ECS parses the value case-insensitively.

This exposes field_matching on SearchSettings as fieldMatching, serialized as Or/And with the same casing as searchMode and as the Agents dotnet client. Defaults to Or, so existing callers are unchanged. Bumps uipath-platform to 0.2.39. Part 1 of 3; uipath-langchain and uipath-agents follow once this publishes.

Dotnet counterpart: UiPath/Agents#6675. Ticket: https://uipath.atlassian.net/browse/ECS-2116

Copilot AI balanced review requested due to automatic review settings October 15, 2026 17:10
@github-actions github-actions Bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-integrations labels Oct 15, 2026
…2116]

Memory search matched when any one field passed its threshold. ECS now
accepts settings.fieldMatching (or | and, default or); expose it on
SearchSettings so callers can request AND matching. Bumps uipath-platform
to 0.2.39.

ECS-2116
@pateljay43
pateljay43 force-pushed the feat/memory-field-matching branch from 981bd82 to bf273b9 Compare October 15, 2026 17:12
@pateljay43 pateljay43 changed the title feat(memory): [1/3] add fieldMatching to memory search settings [ECS-2115] feat(memory): [1/3] add fieldMatching to memory search settings [ECS-2116] Oct 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Serialized field-matching casing needs reconciliation with the wire contract stated in the PR description.

1 open finding
What changed in this PR

Adds configurable field matching to the platform SDK’s memory search settings, preparing for downstream integrations.

Changes:

  • Exports FieldMatching and adds SearchSettings.field_matching, defaulting to OR.
  • Adds request-serialization assertions for default and explicit matching.
  • Bumps uipath-platform to 0.2.39 and updates lockfiles.
File Description
packages/​uipath/​uv.lock Updates platform dependency version.
packages/​uipath-platform/​uv.lock Updates platform package version.
packages/​uipath-platform/​tests/​services/​test_memory_service.py Covers field-matching serialization.
packages/​uipath-platform/​src/​uipath/​platform/​memory/​memory.py Defines matching enum and search setting.
packages/​uipath-platform/​src/​uipath/​platform/​memory/​__init__.py Exports FieldMatching.
packages/​uipath-platform/​pyproject.toml Bumps version to 0.2.39.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🚨 Heads up: uipath-langchain cross-tests are FAILING 🚨

Your changes may break the uipath-langchain-python integration.

⚠️ These checks are NOT enforced by branch protection rules. Please review the failures before merging.

🔍 Inspect the failed run →

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The additive setting preserves existing defaults, includes focused regression coverage, and has no unresolved blocking issues.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

Comment thread packages/uipath/uv.lock
[[package]]
name = "uipath-platform"
version = "0.2.38"
version = "0.2.39"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to update the uipath pyproject.toml to reflect this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. packages/uipath resolves uipath-platform from the local path via [tool.uv.sources], so its lock follows the workspace version on every platform bump. Its pyproject.toml floor (>=0.2.37) only needs raising when uipath itself starts using new platform API, and nothing in uipath uses FieldMatching. Same shape as the last platform-only bump, #1939: platform pyproject plus both locks, uipath pyproject untouched.

@pateljay43
pateljay43 merged commit 05c4020 into main Oct 15, 2026
329 of 336 checks passed
@pateljay43
pateljay43 deleted the feat/memory-field-matching branch October 15, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:uipath-integrations test:uipath-langchain Triggers tests in the uipath-langchain-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants