Adding an overload to MockFileData that takes an object #394

Activity

1. herebebeasties commented on Nov 4, 2018

   

   herebebeasties

   on Nov 4, 2018

   Contributor

   More actions

   FWIW, my view on this is that it's really a very application-specific thing to want to do.

   If you're going to add support for binary object serialization, why isn't there the same thing for XML, JSON, protocol buffers, CSV, YAML, etc?

   They're all arguably equivalent, and arguably used more these days than proprietary .NET serialisation. The reason why not is that this isn't the right layer at which to add such support, as it's really too domain-specific. Yes, it's obviously possible to do it, but it increases the surface area and maintenance effort of the API. If you use binary serialisation a lot it's not exactly hard to add an extension method that does this for you (and that you can use across all IFileSystem implementations).

   👍React with 👍2Reacted by Florian Greinacher and Tatham Oddie
2. tathamoddie commented on Nov 4, 2018

   

   tathamoddie

   on Nov 4, 2018

   Contributor

   More actions

   public static class SavedGameTestExtensions
   {
       public static MockFileData AsMockFile(this SavedGame game)
       {
           return new MockFileData({serialisation logic here});
       }
   }
   

   No need to wrap the wrapper, and it's an opportunity for you to make the domain more readable/visible through the app-specific code.

   var savedGame = new SavedGame({something app specific});
   var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
   {
       { @"c:\mygame.game", savedGame.AsMockFile() }
   });
   
3. padillah commented on Nov 5, 2018

   

   padillah

   on Nov 5, 2018

   Author

   More actions

   Thanks for the feedback. I see what was meant now by "this is a low-level library for IO operations that should stay focused". I'm not used to thinking about "everyone that will use this, ever, for any reason".

   This also gives me ideas on how to approach my object serialization.

   Again, appreciate it.
4. padillah

   closed this as completedon Nov 5, 2018