Skip to content

Key a child's compile on its own task_annotations (v0.1.37) - #86

Merged
Volv-G merged 2 commits into
masterfrom
own-task-annotations-compile-key
Nov 19, 2026
Merged

Volv-G merged 2 commits into
masterfrom
own-task-annotations-compile-key

Conversation

@Volv-G

@Volv-G Volv-G commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

A child's compile key already folds in the call-site defaults pushed into it (subpipeline(child).with_task_annotations(...), #85), but not the child's own @pipeline(task_annotations=...). Two PipelineFn wrappers over one function body, with the same name and config but different own task_annotations, used side by side, therefore shared one compiled child (one sidecar), and the second silently got the first's annotations.

The child's own defaults, resolved as its trace applies them (a mapping, or a function of the child's resolved cfg: its config plus effective overrides), are now part of its compile key, in their own "\x00own_task_annotations" envelope slot. That slot is kept separate from the call-site "\x00task_annotations" slot because the two flow differently: own defaults apply only to the child's body, while call-site defaults also flow on to its descendants. Without own defaults, keys are unchanged.

Tests: wrappers differing only in their own defaults (mapping and function) compile to separate sidecars, each carrying its own annotations. Equal own defaults still share one sidecar, including two distinct functions that resolve to the same mapping.

Bumps the version to 0.1.37.

Raised in review of the shop/world vendoring of tangle-cli @ 078744a: https://delta.shopify.io/shop/world/pull/2480347#discussion_r2600832335882

A child's compile key folded in the call-site defaults pushed into it, but
not its own `@pipeline(task_annotations=...)`. Two wrappers over one function
with the same name and config but different own defaults, used side by side,
shared one sidecar, and the second silently got the first's annotations.

The child's own defaults, resolved as its trace applies them (a mapping, or
a function of the child's cfg), are now part of its compile key. Without
own defaults, keys are unchanged.
@Volv-G
Volv-G requested a review from Ark-kun as a code owner November 19, 2026 01:56
@Volv-G
Volv-G merged commit 91f2a3e into master Nov 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant