fix(sidebar): balance connections strip entries and show both lines - #3247
Merged
Merged
Conversation
A source list rewrites an NSTableCellView's textField to one 13pt run on every layout pass, so the container line never fit the fixed row. The cell no longer uses that outlet, centres its icon and label in a row measured from the label, and the scroll geometry reads where the source list puts its first row.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
A 1x display snaps an odd centring offset to whole pixels, so the space above and below a one-line entry can differ by a point there.
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Connections strip entries put the icon against the top of the highlight and cut the name to one line ("1…"). The database or schema line never appeared. A source list rewrites a cell's
textFieldto one 13pt run on every layout pass, and two 13pt lines did not fit the fixed row.Change
Verified
WorkspaceRailCellRenderingTestshosts the cell in the strip's real table; its font and balance tests fail with the old outlet. Checked on a Debug build at all three sizes, scrolled.Screenshots
Not in this PR
Fixes #3244