Repository navigation
Latest modifications from Dev-iL (addressing #1, #6, #7) - #8
Merged
Merged
Conversation
Feature uitable support
- Added the private methods `waitTillFigureLoaded` and `waitTillWebwindowLoaded`. - Added the public method `waitForFigureReady(hUIFig)` - this blocking method returns only after determining that the UIFigure was fully loaded, or if 2*timeout was reached. - Refactored a couple of functions (getWebWindow, getWidgetID) to make their inner workings much clearer. - TODO: add the new public method to Readme.md. - TODO: test on older MATLAB versions.
- Ignoring hidden figures (that don't have Controllers) when trying to convert hWebwindow -> hUIFigure. - Corrected call to waitTillFigureLoaded. - Improved unfinished warning message.
- widgetID is now a structure (this is more robust). - Refactored helper styling methods - now all go through setStyle. - Adapted TableDemo to new ID conventions. - getWidgetInfo is possibly broken (due to the "registry.byId" call which doesn't work in the general ID_struct case). Internal documentation updated accordingly.
Member
Author
|
Looks like I forgot to update the Readme... :) |
- Cleaned up getWidgetID: separated some experimental fallback functionality into getWidgetIDFromDijit. - Made use of the WidgetID class where appropriate. - Added a warning for unsupported UI objects. - Removed incorrect comment. - Added some useful debugging code at the end. - TODO: make uniform indentation width (2 or 4). - TODO: be consistent instead of "hWin, win, hWebwindow" etc.
- Method is now known as aboutJSLibs(). - Method now also returns the ReactJS version. - Dojo version is now returned as a string (or on older versions, a JSON-stripped char vector). - Added some more debugging commands for exploring React.
This addresses issue #9.
- Added information about new/changed methods. - Added breaks (----) to improve readability. - Modified some aspects of the document according to the conventions of https://github.com/DavidAnson/markdownlint/blob/v0.6.4/doc/Rules.md . - aboutJSLibs() - Dojo version is now returned as a character array for newer MATLAB versions too.
(Reverted the implmented suggestion to remove double whitespace line endings @ Methods list)
sco1
previously requested changes
Jan 7, 2018
sco1
left a comment
Member
There was a problem hiding this comment.
Other than getWebElements needing a warning toggle, LGTM. Addresses the current issues on both of my test machines.
As per review comment.
Member
Author
|
@sco1 Please merge when you're done testing (assuming there are no further comments). |
This was referenced Jan 7, 2018
Member
|
Thanks @Dev-iL, you're a magician :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.