Repository navigation
Chore: MOBILE-140 - Apply kotlin-android on AGP 9 when builtInKotlin is off - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOBILE-140
What does this PR do? 🧐
Fixes the Android build of this plugin for apps on AGP 9 that set
android.builtInKotlin=false, and releases it as 0.8.2.android/build.gradle- the plugin now applieskotlin-androidwhen the app's AGP major version is below 9 or when the app setsandroid.builtInKotlin=false. Before, 0.8.1 applied it only below AGP 9.pubspec.yaml-version: 0.8.1->0.8.2.CHANGELOG.md- new## 0.8.2section. The## Unreleaseddocs line from Chore: MOBILE-4162 - Repoint homepage and podspec author at the Spring Health fork #14 now ships in 0.8.2..github/workflows/build.yml- both build jobs now check out into a folder namediterable_flutter. The repository is namediterable-flutter, so the default checkout folder wasiterable-flutter, and the Build iOS check failed: SPM rejects the example app's path dependency when the folder name does not match the package name (identity 'iterable-flutter' doesn't match override's identity (directory name) 'iterable_flutter'). The Android change does not cause this failure. Main has had no CI run since 2026-07-22.Why: Apps on Flutter 3.50 often keep
android.builtInKotlin=false(Flutter's migrator adds it), because many plugins still apply the Kotlin Gradle Plugin themselves. Cherubi must keep it: withtrue,app_badge_plusand other plugins fail. With that opt-out on AGP 9, 0.8.1 applied no Kotlin plugin at all. Nothing compiled the plugin's Kotlin sources, and the app build failed withcannot find symbol IterableFlutterPlugin.AGP 8, and AGP 9 with built-in Kotlin on, are unchanged.
Test Evidence
flutter analyze(Flutter 3.47.9)flutter testflutter pub publish --dry-runpublish_to: none)builtInKotlin=false, this change through a local overrideHow should this be manually tested? 🤓
android.builtInKotlin=falseinandroid/gradle.properties, pointiterable_flutterat this branch.flutter build apk --debug- expect success. On 0.8.1 the same build fails withcannot find symbol IterableFlutterPlugin.android.builtInKotlin=falseand build again - expect success (built-in Kotlin path, unchanged).Edge Cases
Falseorfalsealso count as off.Any background context you want to provide? 🤗
Found during the Cherubi Flutter 3.50.0 upgrade (SpringCare/cherubi#8428). Cherubi will pin
ref: 0.8.2after this merges and the tag exists.See https://docs.flutter.dev/release/breaking-changes/migrate-to-built-in-kotlin