Repository navigation
CI checks aren't run against staging #795
Description
This means the only time CI checks are going to run is before doing a release, which isn't ideal. We should be running CI checks in every development PR as well. However, this is now not possible because we haven't released the development versions of dependencies (such as solid-logic). As a result, the current CI for staging is broken: https://github.com/SolidOS/solid-ui/actions/runs/27531922777
PS: unrelated to this, we should also be running typecheck and typecheck-test checks on CI.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
- Status
Activity
timea-solid commentedon Jun 15, 2026
Thank you for the workaround.
P.s. Typechecks are usually part of the
npm run buildcall, so they should run.SolidOS#795 Fix tests
SolidOS#795 Add CI setup script for dependency management
SolidOS#795 Run CI against staging and typecheck tests
SolidOS#795 Fix tests
bourgeoa commentedon Jun 15, 2026
The issue is mainly
The easiest solution for me is to build pre-release version of
solid-logicandsolid-uiThe CI already includes an
npm-publish-devthat can run fromstaging.Actually it can run from any branch .
stagingshould be enoughYou just need
npm version prereleasehttps://docs.npmjs.com/cli/v8/commands/npm-versionThe script tags the prerelease version with
dev. Which makes it convenient to use the last one. ex:npm i solid-ui@devI would not like to over complicate dependency management.
NoelDeMartin commentedon Jun 16, 2026
I agree, in fact what you're talking about is the 2nd solution I mentioned in the PR which I think is the best long-term (besides the monorepo). I just opened the PR as a temporary fix until we sort this out... But if we all agree that prereleases are the way to go, we can start using them and we can close my PR.
One thing to note, though. You mention that you can run
npm i solid-ui@devto get this working, but ideally this should work without having to add any additional commands in CI (again, my script was just a workaround). If we move forward with this, we should probably update the package.json of the libraries to depend ondev, and then before making a release we lock it to a released dependency. Which should be fine, since we're already doing a release commit to bump the version anyways, we may as well use that same commit to lock the dependencies.timea-solid commentedon Jun 16, 2026
I like Noels' idea with having the dev prerelease on staging. 👍🏻 I believe this is how I had it in other teams too.
SolidOS#795 Fix tests
SolidOS#795 Run test typechecks
timea-solid commentedon Jun 22, 2026
We decided, for now, to release to npm from staging on all repos.