Repository navigation
Task/restructure - #346
Merged
Merged
Task/restructure#346
Conversation
Prompt: Add tests for container-member delegation, hidden-file rules, index/storage-root checks, direct fetchMetadata, successful content loading, and missing-content/missing-content-type failures. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Missing required peers threaten clean CI installs, delete-aware metadata loses the new flag, and a helper test validates the wrong return contract.
2 open issues
What changed in this PR
This PR expands the shared resource API with content retrieval and container helpers, adds public-access metadata tracking, and tightens access-control origin validation.
Changes:
- Add content-and-metadata fetching, resource helpers, and public type exports.
- Track whether WAC-Allow metadata is available and reject credential-bearing URLs as bare origins.
- Extend tests and refresh the dependency lockfile.
| File | Description |
|---|---|
test/resource/resourceMetadata.test.ts |
Test the public-access knowledge flag. |
test/resource/resourceLogic.test.ts |
Cover content fetching, metadata, and resource helpers. |
test/aclLogic.test.ts |
Test rejection of credential-bearing origins. |
src/types.ts |
Define new resource methods and metadata types. |
src/resource/resourceMetadata.ts |
Report WAC-Allow metadata availability. |
src/resource/resourceLogic.ts |
Implement content retrieval and resource helpers. |
src/index.ts |
Export resource API types. |
src/acl/accessControlSubjects.ts |
Tighten origin validation and use shared logging. |
package-lock.json |
Refresh dependencies and remove peer dependency entries. |
Review effort: Balanced
SharonStrats
force-pushed
the
task/restructure
branch
from
October 22, 2026 05:56
4151923 to
0a0499e
Compare
timea-solid
approved these changes
Oct 22, 2026
SharonStrats
force-pushed
the
task/restructure
branch
from
October 23, 2026 01:28
0a0499e to
884f8c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move helpers to resource for the folder pane work so that they can be used by multiple panes. Also move the content fetch from source pane, this was work that I should have done earlier but needed to research a bit more to be sure that it belonged here.