Skip to content

Annotate failing tests in macOS/Windows test legs #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Annotate failing tests in macOS/Windows test legs #1890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,16 @@ jobs:
TEST_SHARD: ${{ matrix.shard }}
# This leg's share of `cargo test --workspace --no-fail-fast`; the
# shards together run exactly that selection (test_ci_test_shard.py).
# A failing test's panic becomes an annotation, as in `coverage`
# (scripts/ci-test-failures.py).
run: |
python3 scripts/ci-test-shard.py "$TEST_SHARD" 2
set -o pipefail
python3 scripts/ci-test-shard.py "$TEST_SHARD" 2 \
2>&1 | tee "$RUNNER_TEMP/tests.log" || {
status=$?
python3 scripts/ci-test-failures.py "$RUNNER_TEMP/tests.log" || true
exit "$status"
}

test-release:
# Each PR and main push runs the complete release-mode suite. The merge
Expand Down Expand Up @@ -620,7 +628,15 @@ jobs:
env:
TEST_SHARD: ${{ matrix.shard }}
TEST_SHARD_COUNT: ${{ strategy.job-total }}
run: python3 scripts/ci-test-shard.py "$TEST_SHARD" "$TEST_SHARD_COUNT" --locked --profile ci-release
# Failing tests' panics become annotations, as in `test`.
run: |
set -o pipefail
python3 scripts/ci-test-shard.py "$TEST_SHARD" "$TEST_SHARD_COUNT" --locked --profile ci-release \
2>&1 | tee "$RUNNER_TEMP/tests.log" || {
status=$?
python3 scripts/ci-test-failures.py "$RUNNER_TEMP/tests.log" || true
exit "$status"
}

coverage:
if: ((github.event.pull_request.draft != true) && needs.release-readiness.outputs.pr_unchanged != 'true') && (inputs.os != 'windows' && inputs.os != 'macos')
Expand Down
Loading