Skip to content

Delete the stray actions/cache launch.json and replace the 39 dangling "DESIGN §" citations #649

Description

[agent] Filed by the scheduled architecture audit routine (CLI and core). Register: C08.

Kind: refactor (repository hygiene). Source: review §1 #8; Part 8.5 J; register C08.

Problem (verified on main 045d7ec)

  1. A stray vendored editor file. .github/actions/actions/cache/0057852bfaa89a56745cba8c7296529d2fc39830/.vscode/launch.json`` is a Jest launch configuration from actions/cache's own repository. It is the only file under `.github/actions/actions/`, nothing references the path, and it came in with Keep Composer redirects and rollback consistent #358 (`de316b4`), which is unrelated.

  2. 39 citations of a document that isn't in this repository. git grep -c "DESIGN §" finds 39 occurrences across 20 files:

    The cited sections (§1.1, §2.3, §4.2, §4.5, §8.3, §8.4) belong to the vlt integration design, which lives outside this repository (the watchdog comment mentions "the depscan rollout"). A reader of this repository can't resolve any of them.

The third part of the review item (the README documenting v5 while the installer installs v4) is already fixed: README.md#L19-L22 now says the install commands select the latest published release. The dead CI path filters belong to the CI janitor.

Symptoms

None filed. Impact: low. The citations are dead links, and the vendored file is noise in .github/.

Proposed change

  • Delete .github/actions/actions/ entirely.
  • For each DESIGN §x citation, replace it with what it states, either inline (one clause) or as a link to the in-repo source of truth: docs/testing/vlt-compatibility.md, the relevant CLI_CONTRACT.md section, or the test that pins the rule. Where the citation only labels provenance, drop it.
  • Optional: add a check line to an existing docs freshness test (if one is in place by then) that rejects DESIGN §.

Size and scope

Comments and docs only; no production code. About 40 one-line edits across 20 files, plus one file deleted. Out of scope: rewriting the vlt test comments beyond the citation.

Acceptance criteria

  • git ls-files .github/actions/actions is empty.
  • git grep -n "DESIGN §" returns nothing.
  • Every replaced citation still conveys the rule it pointed to (each layout and boundary claim keeps its content or a resolvable link).
  • CI is green, and the workflow YAML still parses (only comments change).

Dependencies

None. This can land at any time.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:triagedarch-auditFiled by a scheduled architecture audit routine (see the architecture review discussion)priority:p3refactorStructural change: duplicated code or logic, missing abstraction, layering, dead code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions