Repository navigation
Msue 236 upgrade react native - #47
iprysiazhnyi-sift merged 12 commits into
Conversation
Fixes tests
fix: remove ngupta, update CHANGELOG.md adn README.md
Removed CODE_OF_CONDUCT.md and CONTRIBUTING.md documentation from the changelog.
Updated the description to clarify the SDK's purpose and added links to iOS and Android SDKs.
Removed the Overview section from the README.
iprysiazhnyi-sift
left a comment
There was a problem hiding this comment.
Please also split the requirements for the installing and using the lib with the requirements for the working with the examples.
Add instructions how to set up the lib in ios/android projects
| cd example/ios | ||
| bundle install # Install Ruby dependencies (first time only) | ||
| bundle exec pod install | ||
| cd ../.. |
There was a problem hiding this comment.
If it's required for the lib development why is it required to go into the example folder?
| implementation 'com.android.support:support-v4:27.0.2' | ||
| ```bash | ||
| cd example/ios | ||
| bundle install # Install Ruby dependencies (first time only) |
There was a problem hiding this comment.
It looks like the Ruby should be preinstall right? Please, add instructions to install it before executing this line
There was a problem hiding this comment.
Install Ruby version manager: brew install rbenv
and run: rbenv install
| ```bash | ||
| cd example/ios | ||
| bundle install # Install Ruby dependencies (first time only) | ||
| bundle exec pod install |
There was a problem hiding this comment.
it looks like the xcode version should be higher than specified in prerequirements, for this command I got the following:
React Native requires XCode >= 16.1. Found 15.4.
| fun setPageName(pageName: String) { | ||
| // Some SDKs use screen name APIs differently; update if needed. | ||
| // Keeping as a no-op or adjust to your SDK’s call. | ||
| // Example: Sift.setPageName(pageName) <-- if such API exists |
There was a problem hiding this comment.
missed implementation
Overview
This request represents a major upgrade of the sift-react-native library, updating React Native to the latest version and integrating the latest Sift iOS SDK. The changes include significant infrastructure improvements, dependency updates, and modernization of the build system.
Key Changes
🚀 React Native Upgrade
0.62.2to0.81.116.11.0to19.1.0📦 Package Manager & Build System
.yarnrc.ymlconfiguration@react-native-community/bobtoreact-native-builder-bobv0.40.13turbo.json)🛠️ Development Tooling
eslint.config.mjs)tsconfig.build.jsonfor build-specific TypeScript configuration📱 iOS Changes
.m) to Objective-C++ (.mm)ios/SiftReactNative.m→ios/SiftReactNative.mmsampletoSiftReactNativeExampleAppDelegate.swift)🤖 Android Changes
SiftReactNativeModule.ktandSiftReactNativePackage.kt📝 Example App Modernization
App.js→src/App.tsx.flowconfig)react-native.config.jsfor proper monorepo support📚 Documentation & Project Structure
CODE_OF_CONDUCT.mdandCONTRIBUTING.mdREADME.mdwith new setup instructionsCHANGELOG.md(likely to be regenerated).editorconfigand.gitattributesfor consistent formatting.nvmrcfor Node.js version management.watchmanconfigfor Watchman configuration🔧 Configuration Updates
babel.config.jsto use new React Native presetpackage.jsonwith new scripts and dependencies.gitignoreto exclude new build artifactsStatistics
Breaking Changes
Migration Notes
For users upgrading from previous versions:
yarn installto update dependenciesTesting